From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46975 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PmrjQ-0001mD-Kh
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 12:52:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PmrjP-0005ld-H8
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 12:52:04 -0500
Received: from eu1sys200aog106.obsmtp.com ([207.126.144.121]:50987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PmrjP-0005kj-6Q
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 12:52:03 -0500
Message-ID: <4D5182BF.9050002@st.com>
Date: Tue, 8 Feb 2011 18:51:59 +0100
From: Christophe Lyon <christophe.lyon@st.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3] Softfloat: Add support to softfloat to
	return floatxx_default_nan when, the corresponding target status flag is
	set.
References: <4D50252A.2000100@st.com>
	<AANLkTim_TSvJVnyHFzmOiu52bmMu3_d=4Uz690S15o=1@mail.gmail.com>
In-Reply-To: <AANLkTim_TSvJVnyHFzmOiu52bmMu3_d=4Uz690S15o=1@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 08.02.2011 16:59, Peter Maydell wrote:
> Your subject is a bit long, which can make it wrap annoyingly in git logs.
> I'd suggest something like:
OK.

 

> This is float32_to_float16() but it looks like you've missed
> float16_to_float32() ?

Well, actually I somewhat managed to persuade myself that it was not necessary to patch float16_to_float32(), but looking at it again it seems there are more bugs in that function:
- the ieee parameter shouldn't be used (my ARM ARM does not mention a different behaviour when AH bit is set)
- it calls float32ToCommonNaN(a) where 'a' is a float16 instead of a float32
- this means implementing float16ToCommonNaN, thus float16_is_signaling_nan()

> 
> Otherwise, looks good, and I can confirm that it fixes
> behaviour of VCVT.F32.F64 and VCVT.F64.F32 when
> the FPSCR.DN bit is set.

Thanks for the confirmation.

Christophe.