Re: [PATCH 2/5] Xl interface change plus changes to code it impacts

From: Kamala Narasimhan <kamala.narasimhan@gmail.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2/5] Xl interface change plus changes to code it impacts
Date: Tue, 08 Feb 2011 14:04:05 -0500	[thread overview]
Message-ID: <4D5193A5.9030508@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102081542120.7277@kaball-desktop>

>> diff -r e4406b9fb064 tools/libxl/libxl_device.c
>> --- a/tools/libxl/libxl_device.c	Mon Feb 07 15:04:32 2011 +0000
>> +++ b/tools/libxl/libxl_device.c	Mon Feb 07 11:28:10 2011 -0500
>> @@ -121,31 +121,24 @@ out:
>>      return rc;
>>  }
>>  
>> -char *libxl__device_disk_string_of_phystype(libxl_disk_phystype phystype)
>> +char *libxl__device_disk_string_of_format(libxl_disk_format format)
>>  {
>> -    switch (phystype) {
>> -        case PHYSTYPE_QCOW: return "qcow";
>> -        case PHYSTYPE_QCOW2: return "qcow2";
>> -        case PHYSTYPE_VHD: return "vhd";
>> -        case PHYSTYPE_AIO: return "aio";
>> -        case PHYSTYPE_FILE: return "file";
>> -        case PHYSTYPE_PHY: return "phy";
>> -        case PHYSTYPE_EMPTY: return "file";
>> -        default: return NULL;
>> +    switch (format) {
>> +        case DISK_FORMAT_QCOW: return "qcow";
>> +        case DISK_FORMAT_QCOW2: return "qcow2"; 
>> +        case DISK_FORMAT_VHD: return "vhd"; 
>> +        case DISK_FORMAT_RAW:
>> +        case DISK_FORMAT_EMPTY: return "file"; 
> 
> This should be return "aio".
>
When I tested, both "aio" and "file" worked and I went with "file".  But if it
is better to go with "aio", I will do that.

Kamala