From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] KVM call minutes for Feb 8 Date: Tue, 08 Feb 2011 15:11:22 -0600 Message-ID: <4D51B17A.90408@codemonkey.ws> References: <20110208155557.GM6198@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Markus Armbruster , Chris Wright , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Peter Maydell Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:40485 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752273Ab1BHVMt (ORCPT ); Tue, 8 Feb 2011 16:12:49 -0500 Received: by eye27 with SMTP id 27so3293695eye.19 for ; Tue, 08 Feb 2011 13:12:48 -0800 (PST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 02/08/2011 01:02 PM, Peter Maydell wrote: > On 8 February 2011 17:13, Markus Armbruster wrote: > >> As far as qdev's concerned, I can see two kinds of to-dos: >> >> * Further develop qdev so that more of the machine init code can becomes >> qdev declarations. Specific ideas welcome. Patches even more, as >> always. >> >> * Convert the remaining devices. They are typically used only with >> oddball machines, which makes the conversion hard to test for anyone >> who's not already using them. >> >> I've said this before: at some point in time (sooner rather than >> later, if you ask me), we need to shoot the stragglers. I'm pretty >> optimistic that any victims worth keeping will receive timely >> attention then. >> > So on IRC pbrook wrote: > So we have a bunch of devices that nominally claim to use the > qdev infrastructure, but are still making assumptions that qdev was > supposed to remove, so break horribly when you actually try to use it > as intended. > > ...and my question is: where is the documentation on how to do > a good conversion of a device to qdev, how it works, what the > assumptions you can/can't make are, etc ? It's basically good OOP modelling and the way qdev is structured today makes it very easy to do bad OOP modelling. Regards, Anthony Liguori > I can't see anything > relevant in the source tree or on the website, but maybe I'm just > looking in the wrong places... > > -- PMM > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44420 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pmusj-0000Gi-Hm for qemu-devel@nongnu.org; Tue, 08 Feb 2011 16:13:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pmurh-00023g-03 for qemu-devel@nongnu.org; Tue, 08 Feb 2011 16:13:39 -0500 Received: from mail-wy0-f173.google.com ([74.125.82.173]:56382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pmurg-00023b-LY for qemu-devel@nongnu.org; Tue, 08 Feb 2011 16:12:48 -0500 Received: by wyg36 with SMTP id 36so6444340wyg.4 for ; Tue, 08 Feb 2011 13:12:48 -0800 (PST) Message-ID: <4D51B17A.90408@codemonkey.ws> Date: Tue, 08 Feb 2011 15:11:22 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] KVM call minutes for Feb 8 References: <20110208155557.GM6198@x200.localdomain> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Chris Wright , Markus Armbruster , kvm@vger.kernel.org, qemu-devel@nongnu.org On 02/08/2011 01:02 PM, Peter Maydell wrote: > On 8 February 2011 17:13, Markus Armbruster wrote: > >> As far as qdev's concerned, I can see two kinds of to-dos: >> >> * Further develop qdev so that more of the machine init code can becomes >> qdev declarations. Specific ideas welcome. Patches even more, as >> always. >> >> * Convert the remaining devices. They are typically used only with >> oddball machines, which makes the conversion hard to test for anyone >> who's not already using them. >> >> I've said this before: at some point in time (sooner rather than >> later, if you ask me), we need to shoot the stragglers. I'm pretty >> optimistic that any victims worth keeping will receive timely >> attention then. >> > So on IRC pbrook wrote: > So we have a bunch of devices that nominally claim to use the > qdev infrastructure, but are still making assumptions that qdev was > supposed to remove, so break horribly when you actually try to use it > as intended. > > ...and my question is: where is the documentation on how to do > a good conversion of a device to qdev, how it works, what the > assumptions you can/can't make are, etc ? It's basically good OOP modelling and the way qdev is structured today makes it very easy to do bad OOP modelling. Regards, Anthony Liguori > I can't see anything > relevant in the source tree or on the website, but maybe I'm just > looking in the wrong places... > > -- PMM > >