From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Autotest] [KVM-AUTOTEST PATCH] KVM test: refactor kvm_config.py Date: Thu, 10 Feb 2011 13:03:53 +0200 Message-ID: <4D53C619.9080907@redhat.com> References: <1297216207-28375-1-git-send-email-mgoldish@redhat.com> <20110209160603.GO4914@us.ibm.com> <20110209162107.GG3933@otherpad.lan.raisama.net> <20110209233101.GG26301@us.ibm.com> <4D53AC5D.4070507@redhat.com> <4D53BF23.6040808@redhat.com> <4D53C203.4000808@redhat.com> <4D53C25B.3010008@redhat.com> <4D53C412.9070003@redhat.com> <4D53C4A4.6070700@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, Uri Lublin , Eduardo Habkost , kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20234 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754597Ab1BJLD6 (ORCPT ); Thu, 10 Feb 2011 06:03:58 -0500 In-Reply-To: <4D53C4A4.6070700@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/10/2011 12:57 PM, Michael Goldish wrote: > > > > I can't easily think of a case where this might cause confusion. The > > purpose of this is to allow people to write: > > > > only qcow2..raw..rtl8139 > > > > without having to remember the order in which those were defined in > > tests_base.cfg. > > Sorry, I meant something like > > only qcow2..hugepages..rtl8139 > > Obviously qcow2 and raw can't coexist. The config files describe a cartesian product, in which order matters. [A B C] x [1 2] generates [A1 A2 B1 B2 C1 C2]; no confusion here if you specify A..1 however [A B C] x [A B] generates [AA AB BA BB CA CB]; A..B is ambiguous we might require that keywords be unique. -- error compiling committee.c: too many arguments to function