From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trilok Soni Subject: Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows and columns Date: Thu, 10 Feb 2011 17:50:14 +0530 Message-ID: <4D53D7FE.9070206@codeaurora.org> References: <1296568063-12010-1-git-send-email-aghayal@codeaurora.org> <1296568063-12010-2-git-send-email-aghayal@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-input-owner@vger.kernel.org To: Eric Miao Cc: Anirudh Ghayal , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, rtc-linux@googlegroups.com, linux-arm-msm@vger.kernel.org, Dmitry Torokhov List-Id: linux-arm-msm@vger.kernel.org Hi Dmitry, On 2/9/2011 1:32 PM, Eric Miao wrote: > On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal wrote: >> From: Trilok Soni >> >> Some keyboard controller have support for more than >> 16 columns and rows. Moving this value to 32. >> >> Cc: Eric Miao >> Cc: Dmitry Torokhov >> Signed-off-by: Trilok Soni > > This looks good to me, as long as the bits don't exceed 256, which > is used in the #KEY() macro. So far, 32 looks to be a sane number > to me, unless we have further requirement to get this larger. > > Acked-by: Eric Miao > Are you going to pick up this patch only from the series you want us to get it submitted it separately? ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.