From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39976 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PoxFx-0002Cm-2j
	for qemu-devel@nongnu.org; Mon, 14 Feb 2011 07:10:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1PoxFw-0004tq-2w
	for qemu-devel@nongnu.org; Mon, 14 Feb 2011 07:10:16 -0500
Received: from e35.co.us.ibm.com ([32.97.110.153]:57251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1PoxFv-0004te-R8
	for qemu-devel@nongnu.org; Mon, 14 Feb 2011 07:10:15 -0500
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p1EBttcj005817
	for <qemu-devel@nongnu.org>; Mon, 14 Feb 2011 04:55:55 -0700
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p1ECADXX123010
	for <qemu-devel@nongnu.org>; Mon, 14 Feb 2011 05:10:13 -0700
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p1EC7nll019856
	for <qemu-devel@nongnu.org>; Mon, 14 Feb 2011 05:07:49 -0700
Message-ID: <4D591B9C.8060705@linux.vnet.ibm.com>
Date: Mon, 14 Feb 2011 06:10:04 -0600
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1296506599-7126-1-git-send-email-aliguori@us.ibm.com>
	<4D590A93.8080407@redhat.com>
In-Reply-To: <4D590A93.8080407@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through
	'change vnc ""'
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Neil Wilson <neil@aldur.co.uk>, qemu-devel@nongnu.org

On 02/14/2011 04:57 AM, Gerd Hoffmann wrote:
> On 01/31/11 21:43, Anthony Liguori wrote:
>> commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a 
>> regression in the
>> change vnc password command that changed the behavior of setting the VNC
>> password to an empty string from disabling login to disabling 
>> authentication.
>>
>> This commit refactors the code to eliminate this overloaded semantics in
>> vnc_display_password and instead introduces the 
>> vnc_display_disable_login.   The
>> monitor implementation then determines the behavior of an empty or 
>> missing
>> string.
>
> Hmm, now about simply never ever changing vs->auth?

If auth is none and you do a vnc change password "" then if we don't set 
vs->auth to vnc, it won't have the desired effect.  I really dislike the 
semantics of this command but that was a past mistake.

Regards,

Anthony Liguori

>
> cheers,
>   Gerd
>