From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [RFC] qapi: events in QMP
Date: Mon, 14 Feb 2011 08:39:11 -0600 [thread overview]
Message-ID: <4D593E8F.7050306@codemonkey.ws> (raw)
In-Reply-To: <20110214104517.32b77291@doriath>
On 02/14/2011 06:45 AM, Luiz Capitulino wrote:
> So the question is: how does the schema based design support extending
> commands or events? Does it require adding new commands/events?
>
Well, let me ask you, how do we do that today?
Let's say that I want to add a new parameter to the `change' function so
that I can include a salt parameter as part of the password.
The way we'd do this today is by checking for the 'salt' parameter in
qdict, and if it's not present, use a random salt or something like that.
However, if I'm a QMP client, how can I tell whether you're going to
ignore my salt parameter or actually use it? Nothing in QMP tells me
this today. If I set the salt parameter in the `change' command, I'll
just get a success message.
Even if we expose a schema, but leave things as-is, having to parse the
schema as part of a function call is pretty horrible, particularly if
distros do silly things like backport some optional parameters and not
others. If those optional parameters are deeply nested in a structure,
it's even worse.
OTOH, if we introduce a new command to set the password with a salt, it
becomes very easy for the client to support. The do something as simple as:
if qmp.has_command("vnc-set-password-with-salt"):
qmp.vnc_set_password_with_salt('foobar', 'X*')
else:
window.set_weak_security_icon(True)
qmp.vnc_set_password('foobar')
Now you could answer, hey, we can add capabilities then those
capabilities can quickly get out of hand.
Regards,
Anthony Liguori
> While the current code is in really in bad shape currently, I'm not sure that
> having this disadvantage will pay off the new design.
>
>
next prev parent reply other threads:[~2011-02-14 14:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 18:08 [Qemu-devel] [RFC] qapi: events in QMP Anthony Liguori
2011-02-13 18:15 ` Anthony Liguori
2011-02-14 9:50 ` [Qemu-devel] " Kevin Wolf
2011-02-14 12:03 ` Anthony Liguori
2011-02-14 12:32 ` Kevin Wolf
2011-02-14 12:45 ` Luiz Capitulino
2011-02-14 14:39 ` Anthony Liguori [this message]
2011-02-14 18:34 ` Luiz Capitulino
2011-02-14 19:34 ` Anthony Liguori
2011-02-14 19:58 ` Luiz Capitulino
2011-02-14 20:01 ` Luiz Capitulino
2011-02-14 20:15 ` Anthony Liguori
2011-02-15 13:35 ` Luiz Capitulino
2011-02-15 14:54 ` Markus Armbruster
2011-02-15 9:20 ` Kevin Wolf
2011-02-15 13:38 ` Luiz Capitulino
2011-02-16 0:59 ` Anthony Liguori
2011-02-16 8:50 ` Kevin Wolf
2011-02-16 13:43 ` Anthony Liguori
2011-02-16 14:15 ` Kevin Wolf
2011-02-16 14:32 ` Anthony Liguori
2011-02-16 14:32 ` Anthony Liguori
2011-02-14 21:14 ` Anthony Liguori
2011-02-14 13:28 ` Luiz Capitulino
2011-02-14 13:33 ` Daniel P. Berrange
2011-02-14 14:24 ` Anthony Liguori
2011-02-14 14:32 ` Anthony Liguori
2011-02-15 14:07 ` What's QAPI? (was: [Qemu-devel] [RFC] qapi: events in QMP) Markus Armbruster
2011-02-15 14:13 ` [Qemu-devel] Re: What's QAPI? Anthony Liguori
2011-02-15 16:15 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D593E8F.7050306@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.