From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] gatserver: Add ATS5 command feature
Date: Mon, 14 Feb 2011 09:53:02 -0600 [thread overview]
Message-ID: <4D594FDE.7030904@gmail.com> (raw)
In-Reply-To: <1297346382-20135-1-git-send-email-olivier.guiter@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
Hi Olivier,
On 02/10/2011 07:59 AM, Olivier Guiter wrote:
> ---
> gatchat/gatserver.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
<snip>
> @@ -837,7 +838,11 @@ static char *extract_line(GAtServer *p, struct ring_buffer *rbuf)
> if (*buf == '"')
> in_string = !in_string;
>
> - if ((*buf == ' ' || *buf == '\t') && in_string == FALSE)
> + if (*buf == s5) {
> + if (i != 0)
> + i -= 1;
> + }
> + else if ((*buf == ' ' || *buf == '\t') && in_string == FALSE)
Please note that we follow the Linux kernel coding style, and in fact
the closing brace should be on the same line as the else if. See
CodingStyle document in the linux kernel git for more details.
I've fixed this for you. Patch has been applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2011-02-14 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 13:59 [PATCH 1/1] gatserver: Add ATS5 command feature Olivier Guiter
2011-02-14 15:53 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D594FDE.7030904@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.