From: Milan Broz <mbroz@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Alasdair G Kergon <agk@redhat.com>,
device-mapper development <dm-devel@redhat.com>,
Jens Axboe <axboe@kernel.dk>, Tao Ma <tm@tao.ma>,
linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH][RFC] dm: Do not open log and cow device read-write for read-only mappings
Date: Tue, 15 Feb 2011 17:05:48 +0100 [thread overview]
Message-ID: <4D5AA45C.7050600@redhat.com> (raw)
In-Reply-To: <20110215155018.GM3160@htj.dyndns.org>
On 02/15/2011 04:50 PM, Tejun Heo wrote:
>> That's why I'm arguing EACCES is not a good error to return and EROFS is
>> more appropriate.
>
> Frankly, I don't really mind one way or the other but EROFS isn't
> usually used in those areas. It might make sense for this use case
> and then there will be cases it just feels awkward. This being a dm
> thing, wouldn't it be just better to let dm massage the return value?
It is not DM thing. That code was checking for generic block device.
No DM there (it was from cryptsetup code but not related to DM part).
Yes, code is not perfect but it worked for >5 years. How many userspace
programs it breaks now?
Milan
next prev parent reply other threads:[~2011-02-15 16:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 2:02 block device read-only handling regression in 2.6.38-rc4 (bisected) Milan Broz
2011-02-13 10:58 ` [PATCH] loop: clear read-only flag in loop_clr_fd Tao Ma
2011-02-13 14:11 ` Milan Broz
2011-02-13 15:05 ` Tao Ma
2011-02-13 16:44 ` Milan Broz
2011-02-14 10:30 ` Tejun Heo
2011-02-14 11:47 ` Milan Broz
2011-02-14 13:14 ` [PATCH][RFC] dm: Do not open log and cow device read-write for read-only mappings Milan Broz
2011-02-14 14:09 ` Tejun Heo
2011-02-14 14:23 ` Milan Broz
2011-02-14 15:44 ` Tejun Heo
2011-02-14 23:15 ` NeilBrown
2011-02-15 2:03 ` [dm-devel] " Alasdair G Kergon
2011-02-15 12:17 ` Milan Broz
2011-02-15 12:46 ` Alasdair G Kergon
2011-02-15 15:20 ` Tejun Heo
2011-02-15 15:46 ` Alasdair G Kergon
2011-02-15 15:50 ` Tejun Heo
2011-02-15 16:05 ` Milan Broz [this message]
2011-02-15 16:12 ` Tejun Heo
2011-02-15 16:36 ` Milan Broz
2011-02-15 16:41 ` Tejun Heo
2011-02-15 16:56 ` Alasdair G Kergon
2011-02-16 8:46 ` Tejun Heo
2011-02-16 8:46 ` Tejun Heo
2011-02-15 16:58 ` Milan Broz
2011-02-16 8:39 ` Tejun Heo
2011-02-15 15:16 ` [PATCH] Return EROFS if read-only detected on block device Milan Broz
2011-02-14 14:39 ` [dm-devel] [PATCH][RFC] dm: Do not open log and cow device read-write for read-only mappings Alasdair G Kergon
2011-02-14 14:07 ` [PATCH] loop: clear read-only flag in loop_clr_fd Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5AA45C.7050600@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.