All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	linux-usb@vger.kernel.org, bossart.nospam@gmail.com,
	Alan Stern <stern@rowland.harvard.edu>,
	Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
Subject: Re: [PATCH] USB-sound: prevent kernel panic on disconnect
Date: Thu, 17 Feb 2011 14:52:08 +0100	[thread overview]
Message-ID: <4D5D2808.7060206@ladisch.de> (raw)
In-Reply-To: <20110216235422.GB6375@xanatos>

Sarah Sharp wrote:
> On Mon, Feb 14, 2011 at 06:39:00PM +0100, Takashi Iwai wrote:
> > Clemens Ladisch wrote:
> > > There seems to be a race between snd_usb_pcm_close() and
> > > snd_usb_stream_disconnect().  I think a mutex taken by both functions
> > > should fix this; and all functions that check 'shutdown' probably need
> > > serializing.
> > 
> > Or, rather make sure that snd_usb_release_substreams() is finished
> > before PCM close; actually it should be called in hw_free callback,
> > but currently it's skipped by the shutdown flag check.  I guess this
> > check isn't right.
> > 
> > The serialization of shutdown check is a good point, but this won't
> > hit actual bugs, I suppose.
> 
> Ok.  I don't have the audio expertise to make a patch; can you or
> Clemens make one for Pierre to try out?

I'll try to make a patch until tomorrow.


Regards,
Clemens

  reply	other threads:[~2011-02-17 13:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 22:22 [PATCH] USB-sound: prevent kernel panic on disconnect Sarah Sharp
2011-02-11 22:42 ` Alan Stern
     [not found]   ` <Pine.LNX.4.44L0.1102111737280.13739-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2011-02-14  8:54     ` Clemens Ladisch
2011-02-14 17:39       ` Takashi Iwai
     [not found]         ` <s5hoc6ejz2j.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2011-02-16 23:54           ` Sarah Sharp
2011-02-17 13:52             ` Clemens Ladisch [this message]
2011-02-17 15:16             ` Takashi Iwai
     [not found]               ` <s5hk4gyy9m1.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2011-02-22  9:21                 ` ALSA: usb-audio: fix oops due to cleanup race when disconnecting Clemens Ladisch
     [not found]                   ` <4D63800E.30509-P6GI/4k7KOmELgA04lAiVw@public.gmane.org>
2011-02-22  9:37                     ` Takashi Iwai
     [not found]                       ` <s5hfwrg9zpv.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2011-02-22 20:18                         ` pl bossart
     [not found]                           ` <AANLkTikcXPTZYYwYDunq4pJwzDhxSv5u++jEWN0RU4EQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-22 21:38                             ` Sarah Sharp
2011-02-22 22:19                           ` pl bossart
     [not found]                             ` <AANLkTi=tYR1daV8zWschBikOkcOgWk864n+b-30q4sSD-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-22 23:54                               ` Takashi Iwai
2011-02-22 23:10                         ` pl bossart
     [not found]                           ` <AANLkTimNhi7GT4NbQRrNq6kyrKOQhudF2owf=U_qzQav-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-23  7:17                             ` Takashi Iwai
2011-02-22 12:12                     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5D2808.7060206@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=bossart.nospam@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pierre-louis.bossart@intel.com \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.