All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Nicholas Thomas <nick@bytemark.co.uk>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3 v2] block/nbd: Make the NBD block device use the AIO interface
Date: Fri, 18 Feb 2011 13:23:51 +0100	[thread overview]
Message-ID: <4D5E64D7.4090200@redhat.com> (raw)
In-Reply-To: <1298031391.17006.87.camel@desk4.office.bytemark.co.uk>

Am 18.02.2011 13:16, schrieb Nicholas Thomas:
> On Thu, 2011-02-17 at 19:28 +0000, Nicholas Thomas wrote:
> 
>> Additional testing has revealed that this code breaks the stock
>> nbd-server (the one on sourceforge) when large (well, 1.3MiB) write
>> requests are sent to it.
> 
> ....NBD has a limit of 1MB on the size of write requests.
> NBD_BUFFER_SIZE in qemu-nbd.c - and I'm sure that's what's knocking out
> the standard NBD server too.
> 
> I didn't see any option to tell QEMU to split up writes to a certain
> size before handing them off to the block driver, so I split the writes
> up into multiple acbs. Reworked patch:

Splitting it up manually sounds right.

I haven't had a close look at your patches yet, but one thing that I
noticed is that your patches are corrupted by line wraps. Please
consider using git-send-email to avoid this kind of trouble or configure
your mailer so that it stops doing this.

Kevin

  reply	other threads:[~2011-02-18 12:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 19:40 [Qemu-devel] NBD block device backend - 'improvements' Nicholas Thomas
2011-02-14 20:32 ` Stefan Hajnoczi
2011-02-15 11:09   ` Kevin Wolf
2011-02-15 21:26     ` Nicholas Thomas
2011-02-16 12:00       ` Kevin Wolf
2011-02-17 16:27         ` [Qemu-devel] " Nicholas Thomas
2011-02-17 16:34         ` [Qemu-devel] [PATCH 1/3] NBD library: whitespace changes Nicholas Thomas
2011-02-17 16:34         ` [Qemu-devel] [PATCH 2/3] NBD library: add aio-compatible read/write function Nicholas Thomas
2011-02-17 16:34         ` [Qemu-devel] [PATCH 3/3] block/nbd: Make the NBD block device use the AIO interface Nicholas Thomas
2011-02-17 19:28           ` Nicholas Thomas
2011-02-18 12:16             ` [Qemu-devel] [PATCH 3/3 v2] " Nicholas Thomas
2011-02-18 12:23               ` Kevin Wolf [this message]
2011-02-18 12:55                 ` Nicholas Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5E64D7.4090200@redhat.com \
    --to=kwolf@redhat.com \
    --cc=nick@bytemark.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.