From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45604 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsBlM-0007BM-Ei for qemu-devel@nongnu.org; Wed, 23 Feb 2011 05:16:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsBlL-0006wa-9a for qemu-devel@nongnu.org; Wed, 23 Feb 2011 05:16:04 -0500 Received: from david.siemens.de ([192.35.17.14]:17238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsBlL-0006vl-0i for qemu-devel@nongnu.org; Wed, 23 Feb 2011 05:16:03 -0500 Message-ID: <4D64DE5E.3000904@siemens.com> Date: Wed, 23 Feb 2011 11:15:58 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 00/22] Refactor and cleaup migration code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 2011-02-23 01:44, Juan Quintela wrote: > This series: > - Fold MigrationState into FdMigrationState (and then rename) > - Factorize migration statec creation in a single place > - Make use of MIG_STATE_*, setup through helpers and make them local > - remove relase & cancel callbacks (where used only one in same > file than defined) > - get_status() is no more, just access directly to .state > - current_migration use cleanup, and make variable static > - max_throotle is gone, now inside current_migration > - change get_migration_status() to migration_has_finished() > and actualize single user. > > Please review. Tried checkpatch.pl? :) I can only recommend to include it in personal preparation scripts for patch series. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux