From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59509 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pz9wx-00051D-Dj
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:44:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Pz9wv-00019W-U1
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:44:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7569)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1Pz9wv-00019I-L4
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 11:44:49 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2EFimUR017334
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 11:44:48 -0400
Message-ID: <4D7E37DA.9040509@redhat.com>
Date: Mon, 14 Mar 2011 16:44:26 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 7/7] ccid: configure:
	improve	--enable-smartcard flags
References: <1298460024-23591-1-git-send-email-alevy@redhat.com>
	<1298460024-23591-8-git-send-email-alevy@redhat.com>
In-Reply-To: <1298460024-23591-8-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/23/11 12:20, Alon Levy wrote:
>  * add --enable-smartcard and --disable-smartcard flags
>  * let the nss check only disable building the ccid-card-emulated device
>  * report only if nss is found or not, not smartcard build inclusion
>  * don't link with NSS if --disable-smartcard-nss
> 

The --disable-smartcard flag really should go with the initial smartcard
changes to configure. That way it is possible to test that each
individual patch doesn't break the build when smartcard support is
enabled or disabled. If you add it at the end, you figuring out which
patch is the problem is much harder.

Adding the smartcard-nss flag should go next to the patch that adds the
code relying on the flag.

Cheers,
Jes