From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34131 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzVgB-0002sO-JO for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzVg7-00042j-27 for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:56:59 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:58377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzVg6-00042f-VU for qemu-devel@nongnu.org; Tue, 15 Mar 2011 10:56:55 -0400 Received: by iym7 with SMTP id 7so731822iym.4 for ; Tue, 15 Mar 2011 07:56:54 -0700 (PDT) Message-ID: <4D7F7E33.7060606@codemonkey.ws> Date: Tue, 15 Mar 2011 09:56:51 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit References: <1298460024-23591-1-git-send-email-alevy@redhat.com> <1298460024-23591-5-git-send-email-alevy@redhat.com> <4D7E3236.8050507@redhat.com> <20110314164010.GL31372@playa.tlv.redhat.com> <4D7F5ED0.70401@redhat.com> <4D7F6D3B.8090803@codemonkey.ws> <20110315142545.GC10553@playa.tlv.redhat.com> <4D7F7CF8.1010809@redhat.com> In-Reply-To: <4D7F7CF8.1010809@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: qemu-devel@nongnu.org On 03/15/2011 09:51 AM, Jes Sorensen wrote: > On 03/15/11 15:25, Alon Levy wrote: >>>> I am not sure what is the best way, if it stays in QEMU people will >>>>>> eventually start making modifications to it, without looking at the >>>>>> other copy that is being maintained. >>>> Two copies is not really practical. QEMU should be the place that >>>> owns it and things should be consuming a .so from QEMU. >>>> >> My bad - I thought you didn't want this. I can do a patch to make qemu >> build an .so file if configure gets a "--libs", how does that sound? >> right now that would build just libcacard, I guess libqmp too later? >> or perhaps have a separate Makefile (Makefile.libs)? Have you given this >> any thought? > I think the libs should be built by default as part of the build process > and get installed as part of the regular install. Ie. it becomes part of > the QEMU build process, so it requires a QEMU build to build the support > libraries, but they can be packages into separate RPMs/debs by the > distro people. > > I don't think we want a --libs option that turns the build process into > only producing the libs. No, but you should be able to use options to disable everything but the libs. Likewise, you should be able to disable the libs. This is necessary for distro packaging. Regards, Anthony Liguori > Cheers, > Jes >