From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58184 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PzmJv-0001go-BB
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 04:43:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzmJm-0007l0-9H
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 04:42:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33791)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PzmJl-0007kp-Ur
	for qemu-devel@nongnu.org; Wed, 16 Mar 2011 04:42:58 -0400
Message-ID: <4D8077F7.2050107@redhat.com>
Date: Wed, 16 Mar 2011 09:42:31 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit
References: <1298460024-23591-1-git-send-email-alevy@redhat.com>
	<1298460024-23591-5-git-send-email-alevy@redhat.com>
	<4D7E3236.8050507@redhat.com>
	<20110314164010.GL31372@playa.tlv.redhat.com>
	<4D7F5ED0.70401@redhat.com>
	<20110315131409.GW31372@playa.tlv.redhat.com>
	<4D7F6D79.9090707@codemonkey.ws>
	<20110315142349.GB10553@playa.tlv.redhat.com>
	<4D807378.3010305@redhat.com>
	<20110316084012.GB7413@playa.tlv.redhat.com>
In-Reply-To: <20110316084012.GB7413@playa.tlv.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/16/11 09:40, Alon Levy wrote:
> On Wed, Mar 16, 2011 at 09:23:20AM +0100, Jes Sorensen wrote:
>> It's really not far off, most of it is in the Makefiles. You really just
>> need to have a libcacard flag that is enabled per default (and is
>> required if one asks for --enable-smartcard), but can be switched off,
>> as well as a flag to not build the main bits.
>>
>> Patches are welcome :)
> 
> Yes, I plan to make some. But I think it's better I don't involve it in this series?
> it's already overdue by a year or so. I'll make send it as a separate patch.

Yes, I would recommend you do them as a separate patch set. It should be
pretty easy to get in.

It would be nice if the switches allows you to enable/disable individual
applications such as qemu-img/qemu-nbd/qemu etc.

Cheers,
Jes