From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Don Zickus <dzickus@redhat.com>
Cc: Shaun Ruffell <sruffell@digium.com>,
maciej.rutecki@gmail.com, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>, Lin Ming <ming.m.lin@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>,
Robert Richter <robert.richter@amd.com>
Subject: Re: [regression 2.6.39-rc2][bisected] "perf, x86: P4 PMU - Read proper MSR register to catch" and NMIs
Date: Thu, 14 Apr 2011 01:25:51 +0400 [thread overview]
Message-ID: <4DA614DF.5090304@openvz.org> (raw)
In-Reply-To: <20110413212208.GJ16939@redhat.com>
On 04/14/2011 01:22 AM, Don Zickus wrote:
> On Thu, Apr 14, 2011 at 12:43:47AM +0400, Cyrill Gorcunov wrote:
>> On 04/14/2011 12:35 AM, Shaun Ruffell wrote:
>> ...
>>>
>>> I had the first version of the patch running the test builds all night without
>>> any NMIs. I installed this one and ran it through the case where I would
>>> reliably get early NMIs and it still no NMIs.
>>>
>>> So for v2:
>>> Tested-by: Shaun Ruffell <sruffell@digium.com>
>>>
>>> Thanks!
>>
>> Thanks a huge Shaun. The thing is (if only I don't miss something) at moment there is
>> no much difference in which patch to pick up. But as only kgdb dives in or any other
>> subsystem (which say would use same manner of nmi delivery) we might be unmasking
>> lvt entry even if nothing were handled at all, so I bias to a second version.
>
> I agree with the second version. Initially I wanted to enable it in the
> case of the !handled path. But your reasoning makes sense to me, don't
> enable it in the !handled case because you might accidentally do something
> bad.
>
> Cheers,
> Don
OK, thanks for review! Shaun please continue testing it, if all will be fine until tomorrow
we will ask Ingo to pick it up then. Sounds OK for everyone?
(CC'ed a couple of people which were involved into this code snippet)
--
Cyrill
next prev parent reply other threads:[~2011-04-13 21:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 22:30 [regression 2.6.39-rc2][bisected] "perf, x86: P4 PMU - Read proper MSR register to catch" and NMIs Shaun Ruffell
2011-04-07 0:16 ` Don Zickus
2011-04-07 3:18 ` Cyrill Gorcunov
2011-04-07 14:38 ` Shaun Ruffell
2011-04-07 14:43 ` Cyrill Gorcunov
2011-04-13 19:33 ` Maciej Rutecki
2011-04-13 20:01 ` Cyrill Gorcunov
2011-04-13 20:35 ` Shaun Ruffell
2011-04-13 20:43 ` Cyrill Gorcunov
2011-04-13 21:22 ` Don Zickus
2011-04-13 21:25 ` Cyrill Gorcunov [this message]
2011-04-13 21:53 ` Shaun Ruffell
2011-04-14 14:30 ` Shaun Ruffell
2011-04-14 14:33 ` Cyrill Gorcunov
2011-04-14 6:47 ` Ingo Molnar
2011-04-14 7:51 ` Cyrill Gorcunov
2011-04-14 8:05 ` Ingo Molnar
2011-04-14 9:27 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA614DF.5090304@openvz.org \
--to=gorcunov@openvz.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=sruffell@digium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.