From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support Date: Thu, 14 Apr 2011 10:02:55 +0200 Message-ID: <4DA6AA2F.2020306@redhat.com> References: <1302722762-30517-1-git-send-email-prasadjoshi124@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: mingo@elte.hu, kvm@vger.kernel.org, penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, levinsasha928@gmail.com, stefanha@linux.vnet.ibm.com To: Prasad Joshi Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38632 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755401Ab1DNIBP (ORCPT ); Thu, 14 Apr 2011 04:01:15 -0400 In-Reply-To: <1302722762-30517-1-git-send-email-prasadjoshi124@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 13.04.2011 21:26, schrieb Prasad Joshi: > The patch only implements the basic read write support for QCOW version 1 > images. Many of the QCOW features are not implmented, for example > - image creation > - snapshot > - copy-on-write > - encryption Yay, more forks, more code duplication! Have you thought about a way to actually share code with qemu instead of repeating Xen's mistake of copying code, modifying it until merges are no longer possible and then let it bitrot? If you shared code, you also wouldn't have to use an obsolete, but simple-to-implement format, but could use some of the better maintained formats of qemu, like qcow2. Also at least your qcow1.c is lacking the copyright header. Please add this, otherwise you're violating the license. Kevin