From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH v2] kvm tool: add QCOW verions 1 read/write support Date: Thu, 14 Apr 2011 10:12:51 +0200 Message-ID: <4DA6AC83.7000601@redhat.com> References: <1302722762-30517-1-git-send-email-prasadjoshi124@gmail.com> <4DA6AA2F.2020306@redhat.com> <20110414080748.GB23965@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Prasad Joshi , kvm@vger.kernel.org, penberg@kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, levinsasha928@gmail.com, stefanha@linux.vnet.ibm.com To: Ingo Molnar Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46965 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757056Ab1DNILS (ORCPT ); Thu, 14 Apr 2011 04:11:18 -0400 In-Reply-To: <20110414080748.GB23965@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: Am 14.04.2011 10:07, schrieb Ingo Molnar: > > * Kevin Wolf wrote: > >> Also at least your qcow1.c is lacking the copyright header. Please add this, >> otherwise you're violating the license. > > AFAICT it's not a copy, it's a reimplementation - and he credited you in the > CREDITS file, for providing a reference implementation. But we can credit you > to the header as well - Pekka? It's actually not my code, but Fabrice's. I compared get_cluster_offset() and it looks similar enough to me to qualify as a modified copy. Kevin