Re: [Qemu-devel] Question about total_sectors in block/vpc.c

From: Kevin Wolf <kwolf@redhat.com>
To: Lyu Mitnick <mitnick.lyu@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] Question about total_sectors in block/vpc.c
Date: Thu, 14 Apr 2011 10:37:26 +0200	[thread overview]
Message-ID: <4DA6B246.4080302@redhat.com> (raw)
In-Reply-To: <BANLkTimVJb4DkFmKvRhmhAAVZy2t=46N0Q@mail.gmail.com>

Am 13.04.2011 22:59, schrieb Lyu Mitnick:
> Hello Stefan,
> 
> I have a question about get_option_parameter(). I am wondering whether 
> get_option_parameter  is suitable to use instead of doing the search by
> myself 
> in the case like following:
> 
> /* Read out options */
>     while (options && options->name) {
>         if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
>             // do something
>         } else if (!strcmp(options->name, BLOCK_OPT_CLUSTER_SIZE)) {
>            // do something
>         }
>         options++;
>     }

Yes, I think it is, though you need to check whether the option has been
set in order to allow use default values.

Kevin