From: Luca Ceresoli <luca.ceresoli@comelit.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/6] NET: pass source IP address to packet handlers
Date: Tue, 19 Apr 2011 17:26:36 +0200 [thread overview]
Message-ID: <4DADA9AC.2060302@comelit.it> (raw)
In-Reply-To: <m2mxjmjpji.fsf@ohwell.denx.de>
Il 19/04/2011 16:15, Detlev Zundel ha scritto:
> Hi Luca,
>
>> This is needed for the upcoming TFTP server implementation.
>>
>> This also simplifies PingHandler() and fixes rxhand_f documentation.
>>
>> Signed-off-by: Luca Ceresoli<luca.ceresoli@comelit.it>
>> Cc: Wolfgang Denk<wd@denx.de>
>> ---
>> Changes in v2:
>> - fixed checkpatch issues.
>>
>> drivers/net/netconsole.c | 5 +++--
>> include/net.h | 15 ++++++++++-----
>> net/bootp.c | 9 ++++++---
>> net/dns.c | 2 +-
>> net/net.c | 30 +++++++++++++++++-------------
>> net/nfs.c | 2 +-
>> net/rarp.c | 3 ++-
>> net/sntp.c | 3 ++-
>> net/tftp.c | 3 ++-
>> 9 files changed, 44 insertions(+), 28 deletions(-)
>>
> [...]
>
>> diff --git a/net/net.c b/net/net.c
>> index a609632..132f99b 100644
>> --- a/net/net.c
>> +++ b/net/net.c
> [...]
>
>> @@ -1596,11 +1598,12 @@ NetReceive(volatile uchar * inpkt, int len)
>> * IP header OK. Pass the packet to the current handler.
>> */
>> /* XXX point to ip packet */
>> - (*packetHandler)((uchar *)ip, 0, 0, 0);
>> + (*packetHandler)((uchar *)ip, 0, src_ip, 0, 0);
>> return;
>> case ICMP_ECHO_REQUEST:
>> - debug("Got ICMP ECHO REQUEST, return %d bytes \n",
>> - ETHER_HDR_SIZE + len);
>> + debug("Got ICMP ECHO REQUEST, "
>> + "return %d bytes\n",
>> + ETHER_HDR_SIZE + len);
>>
>> memcpy (&et->et_dest[0],&et->et_src[0], 6);
>> memcpy (&et->et_src[ 0], NetOurEther, 6);
> This second hunk is not related to the patch at hand, so strictly
> speaking it should not be in here. It's not enough to NAK the patch
> however, just something to look out for in the future.
Yep, but it's needed for checkpatch compliance.
Luca
next prev parent reply other threads:[~2011-04-19 15:26 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 9:08 [U-Boot] [RFC] Act as a TFTP server Luca Ceresoli
2011-04-13 11:37 ` Wolfgang Denk
2011-04-13 12:47 ` Luca Ceresoli
2011-04-30 19:53 ` Wolfgang Denk
2011-05-03 12:23 ` Luca Ceresoli
2011-05-03 12:36 ` Wolfgang Denk
2011-05-16 20:57 ` Luca Ceresoli
2011-04-14 10:31 ` Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 0/6] " Luca Ceresoli
2011-04-14 16:13 ` Albert ARIBAUD
2011-04-18 16:19 ` [U-Boot] [PATCH v2 " Luca Ceresoli
2011-04-19 14:05 ` Detlev Zundel
2011-05-17 10:03 ` [U-Boot] [PATCH v3 0/5] " Luca Ceresoli
2011-05-17 10:03 ` [U-Boot] [PATCH v3 1/5] TFTP: replace "server" with "remote" in local variable names Luca Ceresoli
2011-05-19 8:11 ` Detlev Zundel
2011-05-19 19:39 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 2/5] TFTP: rename STATE_RRQ to STATE_SEND_RRQ Luca Ceresoli
2011-05-19 8:12 ` Detlev Zundel
2011-05-19 19:39 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 3/5] TFTP: net/tftp.c: add server mode receive Luca Ceresoli
2011-05-19 8:13 ` Detlev Zundel
2011-05-19 19:48 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 4/5] TFTP: add tftpsrv command Luca Ceresoli
2011-05-19 8:12 ` Detlev Zundel
2011-05-19 19:48 ` Wolfgang Denk
2011-05-17 10:03 ` [U-Boot] [PATCH v3 5/5] net/tftp.c: fix typo Luca Ceresoli
2011-05-19 8:13 ` Detlev Zundel
2011-05-19 19:48 ` Wolfgang Denk
2011-04-18 16:19 ` [U-Boot] [PATCH v2 1/6] README: remove spurious line Luca Ceresoli
2011-04-19 14:07 ` Detlev Zundel
2011-04-18 16:19 ` [U-Boot] [PATCH v2 2/6] NET: pass source IP address to packet handlers Luca Ceresoli
2011-04-19 14:15 ` Detlev Zundel
2011-04-19 15:26 ` Luca Ceresoli [this message]
2011-05-12 17:38 ` Wolfgang Denk
2011-04-18 16:19 ` [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote" Luca Ceresoli
2011-04-19 14:18 ` Detlev Zundel
2011-04-19 15:29 ` Luca Ceresoli
2011-04-19 16:28 ` Detlev Zundel
2011-04-19 21:56 ` Luca Ceresoli
2011-04-20 8:17 ` Detlev Zundel
2011-05-04 7:58 ` Luca Ceresoli
2011-05-04 10:37 ` Detlev Zundel
2011-04-20 8:41 ` Detlev Zundel
2011-04-20 10:55 ` Luca Ceresoli
2011-04-20 13:27 ` [U-Boot] checkpatch - theory and practice [was: [PATCH v2 3/6] TFTP: rename "server" to "remote"] Detlev Zundel
2011-05-16 20:35 ` [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote" Luca Ceresoli
2011-05-17 9:38 ` Detlev Zundel
2011-04-30 4:36 ` Mike Frysinger
2011-05-16 20:16 ` Luca Ceresoli
2011-05-12 17:46 ` Wolfgang Denk
2011-05-13 7:36 ` Luca Ceresoli
2011-05-14 16:07 ` Luca Ceresoli
2011-04-18 16:19 ` [U-Boot] [PATCH v2 4/6] TFTP: rename STATE_RRQ to STATE_SEND_RRQ Luca Ceresoli
2011-04-19 14:22 ` Detlev Zundel
2011-04-18 16:19 ` [U-Boot] [PATCH v2 5/6] TFTP: net/tftp.c: add server mode receive Luca Ceresoli
2011-04-19 14:37 ` Detlev Zundel
2011-05-17 8:06 ` Luca Ceresoli
2011-05-17 9:41 ` Detlev Zundel
2011-04-18 16:19 ` [U-Boot] [PATCH v2 6/6] TFTP: add tftpsrv command Luca Ceresoli
2011-04-19 14:39 ` Detlev Zundel
2011-04-30 4:32 ` Mike Frysinger
2011-05-04 7:02 ` Mike Frysinger
2011-04-14 15:52 ` [U-Boot] [PATCH 1/6] README: remove spurious line Luca Ceresoli
2011-04-30 20:19 ` Wolfgang Denk
2011-04-14 15:52 ` [U-Boot] [PATCH 2/6] NET: pass source IP address to packet handlers Luca Ceresoli
2011-04-30 20:22 ` Wolfgang Denk
2011-04-30 20:24 ` Wolfgang Denk
2011-05-03 8:54 ` Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 3/6] TFTP: rename "server" to "remote" Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 4/6] TFTP: rename STATE_RRQ to STATE_SEND_RRQ Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 5/6] TFTP: net/tftp.c: add server mode receive Luca Ceresoli
2011-04-14 15:52 ` [U-Boot] [PATCH 6/6] TFTP: add tftpsrv command Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DADA9AC.2060302@comelit.it \
--to=luca.ceresoli@comelit.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.