From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26636 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106Ab1EELln (ORCPT ); Thu, 5 May 2011 07:41:43 -0400 Message-ID: <4DC28CEE.1080304@redhat.com> Date: Thu, 05 May 2011 08:41:34 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Simon Farnsworth CC: Andy Walls , Hans Verkuil , linux-media@vger.kernel.org, Steven Toth Subject: Re: [PATCH] cx18: Clean up mmap() support for raw YUV References: <4DBFDF71.5090705@redhat.com> <1304423860-12785-1-git-send-email-simon.farnsworth@onelan.co.uk> <201105041032.24644.simon.farnsworth@onelan.co.uk> In-Reply-To: <201105041032.24644.simon.farnsworth@onelan.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit List-ID: Sender: Hi Simon, Em 04-05-2011 06:32, Simon Farnsworth escreveu: > On Tuesday 3 May 2011, Andy Walls wrote: >> Simon, >> >> If these two changes are going in, please also bump the driver version to >> 1.5.0 in cx18-version.c. These changes are significant enough >> perturbation. >> >> End users are going to look to driver version 1.4.1 as the first version >> for proper analog tuner support of the HVR1600 model 74351. >> >> Mauro, >> >> Is cx18 v1.4.1 with HVR1600 model 74351 analog tuner support, without these >> mmap() changes going to be visible in kernel version .39 ? >> > > Mauro, > > If you're going to accept these two patches, would you mind bumping the > version in cx18-version.c for me as you apply them, or would you prefer me to > provide either an incremental patch or a new patch with the bump added? There are a few new warnings with your code: drivers/media/video/cx18/cx18-mailbox.c: In function ‘cx18_mdl_send_to_videobuf’: drivers/media/video/cx18/cx18-mailbox.c:206: warning: passing argument 1 of ‘ktime_get_ts’ from incompatible pointer type include/linux/ktime.h:331: note: expected ‘struct timespec *’ but argument is of type ‘struct timeval *’ drivers/media/video/cx18/cx18-mailbox.c:170: warning: unused variable ‘i’ drivers/media/video/cx18/cx18-mailbox.c:167: warning: unused variable ‘u’ Could you please fix them? Thanks, Mauro