From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy_hcd
Date: Tue, 10 May 2011 15:24:57 +0400
Message-ID: <4DC92089.40305@ru.mvista.com>
References: <1304853414-10234-1-git-send-email-tlinder@codeaurora.org> <1304853414-10234-8-git-send-email-tlinder@codeaurora.org> <20110509174910.GA7025@linutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-bw0-f46.google.com ([209.85.214.46]:35012 "EHLO
	mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752480Ab1EJL0m (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Tue, 10 May 2011 07:26:42 -0400
In-Reply-To: <20110509174910.GA7025@linutronix.de>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Tatyana Brokhman <tlinder@codeaurora.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, greg@kroah.com, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, balbi@ti.com, ablay@codeaurora.org, open list <linux-kernel@vger.kernel.org>

Hello.

On 09-05-2011 21:49, Sebastian Andrzej Siewior wrote:

>> +
>> +	retval = usb_add_hcd(hs_hcd, 0, IRQF_DISABLED | IRQF_SHARED);

> Why IRQF_DISABLED | IRQF_SHARED? you don't interrupts at all.

    Moreover, IRQF_DISABLED is a nop now, see <linux/interrupt.h>.

WBR, Sergei