From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1QJmHY-00037F-KQ
	for qemu-devel@nongnu.org; Tue, 10 May 2011 08:43:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1QJmHX-0003zF-1r
	for qemu-devel@nongnu.org; Tue, 10 May 2011 08:43:20 -0400
Received: from e5.ny.us.ibm.com ([32.97.182.145]:56814)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1QJmHW-0003yS-Vl
	for qemu-devel@nongnu.org; Tue, 10 May 2011 08:43:19 -0400
Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147])
	by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4ACGUGt012138
	for <qemu-devel@nongnu.org>; Tue, 10 May 2011 08:16:30 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p4AChBRN938042
	for <qemu-devel@nongnu.org>; Tue, 10 May 2011 08:43:14 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p4AChBDO029189
	for <qemu-devel@nongnu.org>; Tue, 10 May 2011 08:43:11 -0400
Message-ID: <4DC932DB.2080000@linux.vnet.ibm.com>
Date: Tue, 10 May 2011 08:43:07 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20110506173224.278066589@linux.vnet.ibm.com>
	<20110510040712.GA5823@mail.hallyn.com>
	<4DC91795.1040903@linux.vnet.ibm.com>
	<20110510115935.GA3541@mail.hallyn.com>
In-Reply-To: <20110510115935.GA3541@mail.hallyn.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 00/10] Qemu Trusted Platform Module
	(TPM) integration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, andreas.niederl@iaik.tugraz.at

On 05/10/2011 07:59 AM, Serge E. Hallyn wrote:
> Quoting Stefan Berger (stefanb@linux.vnet.ibm.com):
>> On 05/10/2011 12:07 AM, Serge E. Hallyn wrote:
>>> To get this to compile on top of qemu-kvm, I needed the following
>>> patch to force CONFIG_THREAD on so as to define things like
>>> qemu_mutex_lock:
>>>
>>> Index: qemu-kvm-tpm/configure
>>> ===================================================================
>>> --- qemu-kvm-tpm.orig/configure	2011-05-09 21:19:10.920002303 -0500
>>> +++ qemu-kvm-tpm/configure	2011-05-09 21:19:22.150002305 -0500
>>> @@ -3420,6 +3420,7 @@
>>>             exit 1
>>>         fi
>>>         echo "CONFIG_TPM=y">>   $config_host_mak
>>> +      echo "CONFIG_THREAD=y">>   $config_host_mak
>>>     fi
>>>   fi
>>>
>> That seems to be qemu-kvm specific.
> Hm, yeah, I guess it is.  Wonder what the odds are of that actually
> working then.  Well, I've just about got this and libtpms packaged,
> will hopefully finish up this afternoon and see.
>
> I saw nothing problematic in the patches, but just didn't feel
> qualified to send acks based on simple review, so figured I'd be
> better off actually testing.
>
I am currently making modifications to the patches to support command 
lines like this one to be in line with other devices:

-tpm type=builtin,path=<path>,id=xyz   -device tpm_tis,id=xyz

Typically with command lines like this Qemu also supports multiple 
devices of the same type. With the TPM this is a bit problematic since 
it would need to support multiple TPMs also in the firmware (aka BIOS). 
So I may support this command line but only allow one TPM.

> What is your plan regarding libtpms?  Will you be making actual
> releases at sf.net at some point?
I was going to wait for a review of all the patches here on the ml and 
see the code checked in -- until that hasn't happened anything could 
change. So for now I am keeping libtpms in Fedora Rawhide and then was 
going to produce a libtpms-0.5.2 and make it commonly available via 
Fedora, maybe putting a copy of the library on sf.net. I would hold off 
on packaging and distributing it.

    Stefan