All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Hellstrom <daniel@gaisler.com>
To: sparclinux@vger.kernel.org
Subject: Re: [RFC/PATCH] sparc32/LEON: Cache flush during context switch
Date: Wed, 11 May 2011 12:33:12 +0000	[thread overview]
Message-ID: <4DCA8208.2030409@gaisler.com> (raw)
In-Reply-To: <4DC89ECB.6030309@googlemail.com>


Daniel Hellstrom wrote:

>>
>>    Thus, we can simply replace the whole leon_flush_needed() function
>> body with "return 0;". However, this also destroys the cache information
>> printed at boot time. Therefore, I suggest to add an explicit
>> print_leon3_cache_config() function. This also has the advantage that we
>> can correct the wrong cache terminology by Gaisler. During the Leon 2
>> and 3 development, they mixed up the cache "set" and cache "way" terms.
>> The VHDL code as well as the manuals for these processors are full of
>> these errors, but apparently for Leon4 they got it right. Thumbs up.
>
>
> Please do not change this.

I was referring to the functionality of the leon_flush_needed() code, 
please improve comments and/or clean up code.

Daniel


      parent reply	other threads:[~2011-05-11 12:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10  2:11 [RFC/PATCH] sparc32/LEON: Cache flush during context switch Matthias Rosenfelder
2011-05-10  7:19 ` Daniel Hellstrom
2011-05-10 10:36 ` Matthias Rosenfelder
2011-05-10 11:26 ` Kristoffer Glembo
2011-05-10 22:31 ` Matthias Rosenfelder
2011-05-11  9:46 ` Kristoffer Glembo
2011-05-11 12:33 ` Daniel Hellstrom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DCA8208.2030409@gaisler.com \
    --to=daniel@gaisler.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.