From: "Jan Beulich" <JBeulich@novell.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH linux-2.6.18-xen] fix xenbus_transaction_start() hang caused by double xenbus_transaction_end()
Date: Fri, 13 May 2011 09:15:00 +0100 [thread overview]
Message-ID: <4DCD04A402000078000412DD@vpn.id2.novell.com> (raw)
In-Reply-To: <4DCBB551.7000002@redhat.com>
>>> On 12.05.11 at 12:24, Laszlo Ersek <lersek@redhat.com> wrote:
> fix xenbus_transaction_start() hang caused by double xenbus_transaction_end()
>
> vbd_resize() up_read()'s xs_state.suspend_mutex twice in a row via double
> xenbus_transaction_end() calls. The next down_read() in
> xenbus_transaction_start() (at eg. the next resize attempt) hangs.
>
> See RHBZ#618317.
>
> Thanks for considering.
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Jan Beulich <jbeulich@novell.com>
(I wonder how this ever passed any testing.)
The same would be needed for pv-ops too afaics.
Jan
> ---
> drivers/xen/blkback/vbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/xen/blkback/vbd.c b/drivers/xen/blkback/vbd.c
> --- a/drivers/xen/blkback/vbd.c
> +++ b/drivers/xen/blkback/vbd.c
> @@ -156,6 +156,7 @@
> goto again;
> if (err)
> printk(KERN_WARNING "Error ending transaction");
> + return;
> abort:
> xenbus_transaction_end(xbt, 1);
> }
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-05-13 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 10:24 [PATCH linux-2.6.18-xen] fix xenbus_transaction_start() hang caused by double xenbus_transaction_end() Laszlo Ersek
2011-05-13 8:15 ` Jan Beulich [this message]
2011-05-13 8:41 ` Ian Campbell
2011-05-13 13:49 ` Konrad Rzeszutek Wilk
2011-05-19 9:49 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCD04A402000078000412DD@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=lersek@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.