From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] Accurate boot time measurement
Date: Sun, 15 May 2011 20:03:47 +1000 [thread overview]
Message-ID: <4DCFA503.2070805@gmail.com> (raw)
In-Reply-To: <BANLkTikbUdVza1iLe_Vdj4RsJUwRtO4kQw@mail.gmail.com>
On 15/05/11 03:32, Simon Glass wrote:
> On Sat, May 14, 2011 at 4:34 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>
>> On Friday, May 13, 2011 16:51:59 Simon Glass wrote:
>>> This defines the basics of a new boot time measurement feature. This
>> allows
>>> logging of very accurate time measurements as the boot proceeds, by using
>>> an available microsecond counter.
>>>
>>> To enable the feature, define CONFIG_BOOTSTAGE in your board config file.
>>> Also available is CONFIG_BOOTSTAGE_REPORT which will cause a report to be
>>> printed just before handing off to the OS.
>>
>> this seems to overlap the existing show_boot_progress() code. any chance
>> we
>> can look at these being merged ?
>> -mike
>>
>
> Hi Mike,
>
> Yes I did look at this a few weeks ago. It would be a pretty invasive
> change. That code just uses a whole lot of numbers which presumably are
> approximately how far through the boot process we are. Bootstage is intended
> as a debugging tool for performance tune-up rather than a user display tool.
> I could imagine adding a table to bootstage with the progess number for each
> bootstage id, but then people are going to complain that the bootstage
> report is far to long and includes uninteresting things. I suppose I could
> fix that by including a flag as to whether to report each item or not...but
> it any case as you can see it is not a clear win.
>
> If there is a strong appetite for that sort of patch I'm happy to do it.
>
> Regards,
> Simon
>
Couple of thoughts:
- Macro the definition of show_boot_progress() so it accepts a (const
char *) argument if CONFIG_BOOTSTAGE is defined
- Change BOOTSTAGE_COUNT to CONFIG_MAX_BOOTSTAGE_RECORDS
- Any call to show_boot_progress() with a non-null second argument
causes it to be logged in the next available bootstage record
- After the last bootstage record is filled, no further calls to
show_boot_progress() cause logging to the bootstage records
- Instead of CONFIG_BOOTSTAGE_REPORT, create a command which dumps the
contents of the bootstage records
No this is going to result in a big patch (every instance of
show_boot_progress() will need to be touched to at least add NULL as the
second parameter - Maintainers can add better text later ;)
Regards,
Graeme
next prev parent reply other threads:[~2011-05-15 10:03 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 20:51 [U-Boot] [PATCH 0/4] Accurate boot time measurement Simon Glass
2011-05-13 20:52 ` [U-Boot] [PATCH 1/4] Add microsecond " Simon Glass
2011-05-14 11:19 ` Mike Frysinger
2011-05-14 11:31 ` Mike Frysinger
2011-05-13 20:52 ` [U-Boot] [PATCH 2/4] Add bootstage progress report Simon Glass
2011-05-14 11:42 ` Mike Frysinger
2011-05-13 20:52 ` [U-Boot] [PATCH 3/4] Add bootstage calls in places appropriate for network booting Simon Glass
2011-05-14 11:44 ` Mike Frysinger
2011-05-13 20:52 ` [U-Boot] [PATCH 4/4] Add option to print boot stage report before starting kernel Simon Glass
2011-05-14 11:46 ` Mike Frysinger
2011-05-14 11:34 ` [U-Boot] [PATCH 0/4] Accurate boot time measurement Mike Frysinger
2011-05-14 17:32 ` Simon Glass
2011-05-15 10:03 ` Graeme Russ [this message]
2011-05-15 21:34 ` Simon Glass
2011-05-15 22:56 ` Graeme Russ
2011-05-16 5:56 ` Wolfgang Denk
2011-05-16 6:10 ` Graeme Russ
2011-05-15 11:53 ` Wolfgang Denk
2011-05-15 21:58 ` Simon Glass
2011-05-15 22:36 ` Graeme Russ
2011-05-16 5:55 ` Wolfgang Denk
2011-05-16 6:11 ` Graeme Russ
2011-05-16 11:18 ` Wolfgang Denk
2011-05-16 2:59 ` Mike Frysinger
2011-05-16 5:48 ` Wolfgang Denk
2011-05-16 6:23 ` Graeme Russ
2011-05-16 11:40 ` Wolfgang Denk
2011-05-16 18:25 ` Scott Wood
2011-05-16 23:09 ` Graeme Russ
2011-05-16 14:23 ` Premi, Sanjeev
2011-05-16 16:00 ` Simon Glass
2011-05-16 18:32 ` Wolfgang Denk
2011-05-16 21:35 ` Simon Glass
2011-05-17 8:20 ` Detlev Zundel
2011-05-17 17:00 ` Simon Glass
2011-05-17 22:57 ` Graeme Russ
2011-05-19 8:36 ` Detlev Zundel
2011-05-20 1:48 ` Simon Glass
2011-05-20 2:28 ` Graeme Russ
2011-05-20 2:29 ` Graeme Russ
2011-05-23 15:22 ` Detlev Zundel
2011-05-24 2:55 ` Mike Frysinger
2011-05-24 7:18 ` Wolfgang Denk
2011-05-24 18:22 ` Mike Frysinger
2011-05-24 19:24 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCFA503.2070805@gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.