From: Jens Axboe <jaxboe@fusionio.com>
To: "Alex,Shi" <alex.shi@intel.com>
Cc: "Li, Shaohua" <shaohua.li@intel.com>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Perfromance drop on SCSI hard disk
Date: Tue, 17 May 2011 09:20:30 +0200 [thread overview]
Message-ID: <4DD221BE.3040406@fusionio.com> (raw)
In-Reply-To: <1305612565.21534.2177.camel@debian>
On 2011-05-17 08:09, Alex,Shi wrote:
> On Mon, 2011-05-16 at 16:37 +0800, Alex,Shi wrote:
>>>> what I mean is current sdev (other devices too) can still be added into
>>>> starved list, so only does async execute for current q isn't enough,
>>>> we'd better put whole __scsi_run_queue into workqueue. something like
>>>> below on top of yours, untested. Not sure if there are other recursive
>>>> cases.
>>> verified the regression can be fully fixed by your patch (with my
>>> suggested fix to avoid race). Can we put a formal patch upstream?
>>
>> Yes, we tested Jens patch alone and plus Shaohua's patch too. Both of
>> them recovered SAS disk performance too. Now I am testing them on SSD
>> disk with kbuild and fio cases, In theory, they will both work.
>>
>
> As expected, both patches has no effect on SSD disks in JBD.
I will queue up the combined patch, it looks fine from here as well.
--
Jens Axboe
next prev parent reply other threads:[~2011-05-17 7:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 6:40 Perfromance drop on SCSI hard disk Alex,Shi
2011-05-10 6:52 ` Shaohua Li
2011-05-12 0:36 ` Shaohua Li
2011-05-12 20:29 ` Jens Axboe
2011-05-13 0:11 ` Alex,Shi
2011-05-13 0:48 ` Shaohua Li
2011-05-13 3:01 ` Shaohua Li
2011-05-16 8:04 ` Shaohua Li
2011-05-16 8:37 ` Alex,Shi
2011-05-17 6:09 ` Alex,Shi
2011-05-17 7:20 ` Jens Axboe [this message]
2011-05-19 8:26 ` Alex,Shi
2011-05-19 8:47 ` Alex,Shi
2011-05-19 18:27 ` Jens Axboe
2011-05-20 0:22 ` Alex,Shi
2011-05-20 0:40 ` Shaohua Li
2011-05-20 5:17 ` Alex,Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD221BE.3040406@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.