From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Wed, 18 May 2011 11:29:19 +0300 Message-ID: <4DD3835F.6070702@redhat.com> References: <1305575004-nyh@il.ibm.com> <201105161948.p4GJm1as001742@rice.haifa.ibm.com> <20110517131918.GA3809@amt.cnet> <4DD27998.1040105@redhat.com> <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nadav Har'El" , kvm@vger.kernel.org, gleb@redhat.com To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20057 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755333Ab1ERI31 (ORCPT ); Wed, 18 May 2011 04:29:27 -0400 In-Reply-To: <20110517195253.GB11065@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 05/17/2011 10:52 PM, Marcelo Tosatti wrote: > On Tue, May 17, 2011 at 10:30:30PM +0300, Nadav Har'El wrote: > > On Tue, May 17, 2011, Marcelo Tosatti wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > > > > this is what I planned to do, until it dawned on me that I can't, because "cpu" > > > > isn't part of vmx (where the vmcs and launched sit in the standard KVM), but > > >... > > > vcpu->cpu remains there. There is a new ->cpu field on struct vmcs, just > > > as saved_vmcs has in the current patches, to note the cpu which the VMCS > > > was last loaded. > > > > So we'll have two fields, vmx.vcpu.cpu and vmx.vmcs.cpu, which are supposed > > to always contain the same value. Are you fine with that? > > Yes. Avi? Yes. They have different meanings. vcpu->cpu means where the task that runs the vcpu is running (or last ran). vmcs->cpu means which cpu has the vmcs cached. They need not be the same when we have multiple vmcs's for a vcpu; but vmx->vmcs->cpu will chase vcpu->cpu as it changes. Please post this patch separately instead of reposting the entire series, we can apply it independently. -- error compiling committee.c: too many arguments to function