From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Wed, 18 May 2011 11:31:02 +0300 Message-ID: <4DD383C6.5070001@redhat.com> References: <1305575004-nyh@il.ibm.com> <201105161948.p4GJm1as001742@rice.haifa.ibm.com> <20110517131918.GA3809@amt.cnet> <4DD27998.1040105@redhat.com> <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, gleb@redhat.com To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54679 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546Ab1ERIbI (ORCPT ); Wed, 18 May 2011 04:31:08 -0400 In-Reply-To: <20110518055236.GA1230@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 05/18/2011 08:52 AM, Nadav Har'El wrote: > On Tue, May 17, 2011, Marcelo Tosatti wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > > On Tue, May 17, 2011 at 10:30:30PM +0300, Nadav Har'El wrote: > > > So we'll have two fields, vmx.vcpu.cpu and vmx.vmcs.cpu, which are supposed > > > to always contain the same value. Are you fine with that? > > > > Yes. Avi? > > Oops, it's even worse than I said, because if the new vmclear_local_vmcss > clears the vmcs currently used on some vcpu, it will update vmcs.cpu on that > vcpu to -1, but will *not* update vmx.vcpu.cpu, which remain its old value, > and potentially cause problems when it is used (e.g., in x86.c) instead > of vmx.vmcs.cpu. > I did a quick audit and it seems fine. If it isn't, we'll fix it when we see the problem. -- error compiling committee.c: too many arguments to function