From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC v2] lis3lv02d: avoid divide by zero due to unchecked register read
Date: Wed, 18 May 2011 17:56:18 +0200 [thread overview]
Message-ID: <4DD3EC22.7060907@tremplin-utc.net> (raw)
In-Reply-To: <201105181747.12356.chunkeey@googlemail.com>
Op 18-05-11 17:47, Christian Lamparter schreef:
> On Tuesday 17 May 2011 23:46:00 Éric Piel wrote:
>> Op 16-05-11 23:36, Christian Lamparter schreef:
>>> On Monday 16 May 2011 13:16:46 Éric Piel wrote:
:
>>> Do you know how "volatile" this data rate is? If it never changes
>>> [at least it doesn't here?] then why not read it once in init_device
>>> and store it in the device context?
>> It is not normally changing, normally it is set just at init/unsuspend
>> (where the bios can also interfere sometimes) and when the user changes
>> it.
> Uh, "bios can also interfere"... this sounds very bad. At least for
> my x41t the bios doesn't care about hdaps once the OS is running.
>
>> So definitely within the same function it's not going to suddenly
>> change.
> a SMM can happen at any time and if a faulty BIOS [likely, since I got
> a new laptop] is what caused the crash, I wouldn't bet on "const within
> a function context".
Yes, at least on the HP laptop I have the bios enjoys re-initialising
the hardware at some default value whenever suspend/resume happens.
>> We could avoid calculating/checking it twice in
>> lis3lv02d_selftest(). Care to do a third version with this little clean up?
> I have my doubts, but ok if you say so... Just one thing: need to do some Q&A
> on the code above, I haven't tested it extensively yet.
I didn't know about the SMM... well, then let's keep the code as is.
I'll try to test it on my laptop in the coming days. On which hardware
have you tested it?
Éric
next prev parent reply other threads:[~2011-05-18 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 22:46 [PATCH] lis3lv02d: avoid divide by zero due to unchecked register read Christian Lamparter
2011-05-16 11:16 ` Éric Piel
2011-05-16 21:36 ` [RFC v2] " Christian Lamparter
2011-05-17 21:46 ` Éric Piel
2011-05-18 15:47 ` Christian Lamparter
2011-05-18 15:56 ` Éric Piel [this message]
2011-05-18 16:03 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD3EC22.7060907@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=chunkeey@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.