From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756879Ab1ESIvL (ORCPT ); Thu, 19 May 2011 04:51:11 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:36738 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756843Ab1ESIvJ (ORCPT ); Thu, 19 May 2011 04:51:09 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4DD4D9EB.2040603@jp.fujitsu.com> Date: Thu, 19 May 2011 17:50:51 +0900 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: a.p.zijlstra@chello.nl CC: yong.zhang0@gmail.com, paulmck@linux.vnet.ibm.com, oleg@redhat.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mingo@elte.hu, lizf@cn.fujitsu.com, miaox@cn.fujitsu.com Subject: Re: [PATCH v2 1/2] rcu: don't bind offline cpu References: <20110428161149.GA15658@redhat.com> <20110502194416.2D61.A69D9226@jp.fujitsu.com> <20110502195657.2D68.A69D9226@jp.fujitsu.com> <1305129929.2914.247.camel@laptop> <4DCCC61F.80408@jp.fujitsu.com> <20110515185547.GL2258@linux.vnet.ibm.com> <20110516132623.GA2058@zhy> <4DD4B358.3080705@jp.fujitsu.com> <1305794078.2466.7193.camel@twins> In-Reply-To: <1305794078.2466.7193.camel@twins> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2011/05/19 17:34), Peter Zijlstra wrote: > On Thu, 2011-05-19 at 15:06 +0900, KOSAKI Motohiro wrote: >> >> The right way is, explicit two phase cpu bindings (1) bind boot >> (or any other online) cpu at CPU_UP_PREPARE (2) bind correct >> target cpu at CPU_ONLINE. This patch does it. > > I'm not sure that is in-fact correct. From what I understood, RCU could > have need of this thread before the ONLINE callback and expects it to be > affine at that time. > > What was wrong with delaying the wakeup to STARTING? Grr, I misparsed Paul's mail. I thought he said "Sorry, but this does not work." to you. But in fact, he said to Young. I have to see and test your patch. I'm sorry. Please give me a bit time.