[PATCH 0/1] utils.bbclass: fix for create_wrapper

[PATCH 0/1] utils.bbclass: fix for create_wrapper

[Saul Wold]

From: Saul Wold <sgw@linux.intel.com>


Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: sgw/patch
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgw/patch

Thanks,
    Saul Wold <sgw@linux.intel.com>
---


Saul Wold (1):
  utils.bbclass: modify create_wrapper to correctly follow symlinks

 meta/classes/utils.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.3.4

[PATCH 1/1] utils.bbclass: modify create_wrapper to correctly follow symlinks

[Saul Wold]

From: Saul Wold <sgw@linux.intel.com>

This ensures you look up the symbolic link to get the full path

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/classes/utils.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 6bcaf86..1965d2f 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -312,7 +312,8 @@ create_wrapper () {
    cmdname=`basename $cmd`.real
    cat <<END >$cmd
 #!/bin/sh
-exec env $@ \`dirname \$0\`/$cmdname "\$@"
+realpath=\`readlink -fn \$0\`
+exec env $@ \`dirname \$realpath\`/$cmdname "\$@"
 END
    chmod +x $cmd
 }
-- 
1.7.3.4

Re: [PATCH 1/1] utils.bbclass: modify create_wrapper to correctly follow symlinks

[Gary Thomas]

On 05/18/2011 12:57 PM, Saul Wold wrote:
> From: Saul Wold<sgw@linux.intel.com>
>
> This ensures you look up the symbolic link to get the full path
>
> Signed-off-by: Saul Wold<sgw@linux.intel.com>

Verified - this patch fixes the current breakage in the Poky tree as well.

Thanks

> ---
>   meta/classes/utils.bbclass |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
> index 6bcaf86..1965d2f 100644
> --- a/meta/classes/utils.bbclass
> +++ b/meta/classes/utils.bbclass
> @@ -312,7 +312,8 @@ create_wrapper () {
>      cmdname=`basename $cmd`.real
>      cat<<END>$cmd
>   #!/bin/sh
> -exec env $@ \`dirname \$0\`/$cmdname "\$@"
> +realpath=\`readlink -fn \$0\`
> +exec env $@ \`dirname \$realpath\`/$cmdname "\$@"
>   END
>      chmod +x $cmd
>   }

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [PATCH 0/1] utils.bbclass: fix for create_wrapper

[Richard Purdie]

On Wed, 2011-05-18 at 11:57 -0700, Saul Wold wrote:
> From: Saul Wold <sgw@linux.intel.com>
> 
> 
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>   Branch: sgw/patch
>   Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgw/patch
> 
> Thanks,
>     Saul Wold <sgw@linux.intel.com>
> ---
> 
> 
> Saul Wold (1):
>   utils.bbclass: modify create_wrapper to correctly follow symlinks

Merged to master.

Cheers,

Richard

Re: [PATCH 1/1] utils.bbclass: modify create_wrapper to correctly follow symlinks

[Koen Kooi]

Op 18 mei 2011, om 20:23 heeft Saul Wold het volgende geschreven:

> From: Saul Wold <sgw@linux.intel.com>
> 
> This ensures you look up the symbolic link to get the full path
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/classes/utils.bbclass |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
> index 6bcaf86..a789d41 100644
> --- a/meta/classes/utils.bbclass
> +++ b/meta/classes/utils.bbclass
> @@ -312,7 +312,8 @@ create_wrapper () {
>    cmdname=`basename $cmd`.real
>    cat <<END >$cmd
> #!/bin/sh
> -exec env $@ \`dirname \$0\`/$cmdname "\$@"
> +realpath=`readlink -fn \$0`
> +exec env $@ \`dirname \$realpath\`/$cmdname "\$@"
> END
>    chmod +x $cmd
> }

This patch makes the perl problem come out a lot earlier:

| env: /OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/x86_64-linux/perl-native-5.12.3-r2/temp/perl.real: No such file or directory
| configure: error: Perl 5.005_03 or better is required
| + bbfatal 'oe_runconf failed'
| + echo 'ERROR: oe_runconf failed'
| ERROR: oe_runconf failed
| + exit 1
| ERROR: Function 'do_configure' failed (see /OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/x86_64-linux/autoconf-native-2.65-r2/temp/log.do_configure.16420 for further information)

[PATCH 1/1] utils.bbclass: modify create_wrapper to correctly follow symlinks

[Saul Wold]

From: Saul Wold <sgw@linux.intel.com>

This ensures you look up the symbolic link to get the full path

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/classes/utils.bbclass |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 6bcaf86..a789d41 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -312,7 +312,8 @@ create_wrapper () {
    cmdname=`basename $cmd`.real
    cat <<END >$cmd
 #!/bin/sh
-exec env $@ \`dirname \$0\`/$cmdname "\$@"
+realpath=`readlink -fn \$0`
+exec env $@ \`dirname \$realpath\`/$cmdname "\$@"
 END
    chmod +x $cmd
 }
-- 
1.7.3.4