From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QN3FY-0006Br-9h
	for qemu-devel@nongnu.org; Thu, 19 May 2011 09:26:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QN3FW-0005q8-Ou
	for qemu-devel@nongnu.org; Thu, 19 May 2011 09:26:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22636)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1QN3FW-0005pi-He
	for qemu-devel@nongnu.org; Thu, 19 May 2011 09:26:46 -0400
Message-ID: <4DD51A90.2030108@redhat.com>
Date: Thu, 19 May 2011 16:26:40 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4DD3C5B9.1080908@redhat.com>	<4DD3D236.90708@siemens.com>	<4DD3D95E.2060105@redhat.com>	<4DD3E1B3.3020405@siemens.com>	<BANLkTimYH3-FkVQfdOXO+at2G0NhX-UaVg@mail.gmail.com>	<4DD3E610.1080201@siemens.com>
	<4DD4199E.2000702@codemonkey.ws> <4DD4B94C.3070700@web.de>
	<4DD519DE.90608@codemonkey.ws>
In-Reply-To: <4DD519DE.90608@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] Memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel <qemu-devel@nongnu.org>

On 05/19/2011 04:23 PM, Anthony Liguori wrote:
>> Actually, things are a bit more complicated: This layer has to properly
>> adopt the coalescing properties of underlying regions or we cause
>> performance regressions to VGA emulation. That means it has to register
>> dispatching slots of the corresponding size and set the coalescing flag
>> accordingly. And it likely need to adjust them as the regions below 
>> change.
>
>
> As I mentioned in another thread, I don't think we want to "design" 
> coalescing into the API.  Coalescing is something that breaks through 
> abstractions layers and is really just a hack.

It's impossible not to design it into the API.  The layer which wants to 
do coalescing (the device) has no idea if and where its memory is mapped.

-- 
error compiling committee.c: too many arguments to function