Re: [PATCH] dw_dmac: Replace subsys_init() with arch_initcall()

From: viresh kumar <viresh.kumar@st.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	Armando VISCONTI <armando.visconti@st.com>,
	Shiraz HASHIM <shiraz.hashim@st.com>,
	"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dw_dmac: Replace subsys_init() with arch_initcall()
Date: Fri, 20 May 2011 09:14:13 +0530	[thread overview]
Message-ID: <4DD5E38D.8010709@st.com> (raw)
In-Reply-To: <1305804238.28926.302.camel@vkoul-udesk3>

On 05/19/2011 04:53 PM, Koul, Vinod wrote:
> On Thu, 2011-05-19 at 10:51 +0530, viresh kumar wrote:
>> On 05/18/2011 05:51 PM, Linus Walleij wrote:
>>>>> @Linus: What do you say? Can we get back to module_init() for amba-pl022?
>>>>> And subsys_initcall() for DMA.
>>> No, but I sent a patch that will make it possible to have both
>>> as subsys_init(), check it out, it seems to work for me.
> I am okay with this approach...
> 
> Linus, though I am still not convinced why st-dma would need to be
> arch_init?
> 

I think you missed this. In Linus's patch following is also done.

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index fab68a5..7d3e93d 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2951,4 +2951,4 @@ int __init stedma40_init(void)
 {
        return platform_driver_probe(&d40_driver, d40_probe);
 }
-arch_initcall(stedma40_init);
+subsys_initcall(stedma40_init);

-- 
viresh
