All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsck: don't check/clone duplicate xattr blocks in fs without xattr feature
Date: Mon, 23 May 2011 12:52:10 -0500	[thread overview]
Message-ID: <4DDA9ECA.8000708@redhat.com> (raw)
In-Reply-To: <4D77EAAC.3010208@redhat.com>

On 3/9/11 3:01 PM, Eric Sandeen wrote:
> On 2/9/11 12:41 PM, Eric Sandeen wrote:
>> I had an extremely corrupted customer filesystem which, after thousands
>> of lines of e2fsck output, found one more problem on an immediately
>> subsequent e2fsck.  In short, a file had had its i_file_acl block
>> cloned due to being a duplicate.  That ultimately got cleared
>> because the fs did not have the xattr feature, and the inode
>> was subsequently removed due to invalid mode.
>>
>> The 2nd e2fsck pass found the cloned xattr block as in use, but
>> not owned by any file, and had to fix up the block bitmaps.
>>
>> Simply skipping the processing of duplicate xattr blocks on a
>> non-xattr filesystem seems reasonable, since they will be cleared
>> later in any case.
>>
>> (also fix existing brace misalignment)
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> 
> Ted, ping on this one?  Would like to get it upstream before
> pushing it to RHEL, because as we all know now, that's how
> we roll at Red Hat.  :)

Ping again, for review and/or merge of this one, it's approaching 4 months old now...

Thanks,
-Eric

  reply	other threads:[~2011-05-23 17:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 18:41 [PATCH] e2fsck: don't check/clone duplicate xattr blocks in fs without xattr feature Eric Sandeen
2011-03-09 21:01 ` Eric Sandeen
2011-05-23 17:52   ` Eric Sandeen [this message]
2011-05-23 18:00     ` Eric Sandeen
2011-05-23 18:04       ` Eric Sandeen
2011-06-01  0:00 ` Ted Ts'o
  -- strict thread matches above, loose matches on Subject: below --
2011-02-09 18:41 Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDA9ECA.8000708@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.