From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Tue, 24 May 2011 13:08:42 +0300 Message-ID: <4DDB83AA.8070703@redhat.com> References: <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> <20110518120801.GA9176@amt.cnet> <20110522085732.GB1116@fermat.math.technion.ac.il> <4DDA81FD.5050203@redhat.com> <20110523164325.GF27867@amd.com> <4DDA90AB.5010604@redhat.com> <20110524092206.GH27867@amd.com> <20110524092838.GB136@fermat.math.technion.ac.il> <20110524095717.GA13157@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nadav Har'El" , Marcelo Tosatti , "kvm@vger.kernel.org" , "gleb@redhat.com" To: "Roedel, Joerg" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10630 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752719Ab1EXKIu (ORCPT ); Tue, 24 May 2011 06:08:50 -0400 In-Reply-To: <20110524095717.GA13157@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/24/2011 12:57 PM, Roedel, Joerg wrote: > On Tue, May 24, 2011 at 05:28:38AM -0400, Nadav Har'El wrote: > > On Tue, May 24, 2011, Roedel, Joerg wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > > > Probably we should make the local_vcpu_list from vmx generic, use it > > > from svm and fix it this way. > > > > The point is, local_vcpu_list is now gone, replaced by a loaded_vmcss_on_cpu, > > and vcpu->cpu is not set to -1 for any vcpu when a CPU is offlined - also in > > VMX... > > loaded_vmcss_on_cpu sound similar, probably this can be generalized. It's not the same: there is a main:1 relationship between vmcss and vcpus (like vmcbs and vcpus). However, it may be that the general case for svm also needs to treat individual vmcbs differently. > Is > this code already upstream or is this changed with your nVMX patch-set? > Not upstream yet (however generalization, if needed, will be done after it's upstream). -- error compiling committee.c: too many arguments to function