From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Tue, 24 May 2011 14:36:54 +0300 Message-ID: <4DDB9856.9060206@redhat.com> References: <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> <20110518120801.GA9176@amt.cnet> <20110522085732.GB1116@fermat.math.technion.ac.il> <4DDA81FD.5050203@redhat.com> <20110523185104.GA26899@fermat.math.technion.ac.il> <625BA99ED14B2D499DC4E29D8138F1505C9BEF07A9@shsmsx502.ccr.corp.intel.com> <20110524075656.GA26588@fermat.math.technion.ac.il> <625BA99ED14B2D499DC4E29D8138F1505C9BFA33FE@shsmsx502.ccr.corp.intel.com> <4DDB9105.9050900@redhat.com> <625BA99ED14B2D499DC4E29D8138F1505C9BFA34F7@shsmsx502.ccr.corp.intel.com> <4DDB9616.9010801@redhat.com> <625BA99ED14B2D499DC4E29D8138F1505C9BFA34FE@shsmsx502.ccr.corp.in tel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Nadav Har'El" , Marcelo Tosatti , "kvm@vger.kernel.org" , "gleb@redhat.com" , "Roedel, Joerg" To: "Tian, Kevin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546Ab1EXLhK (ORCPT ); Tue, 24 May 2011 07:37:10 -0400 In-Reply-To: <625BA99ED14B2D499DC4E29D8138F1505C9BFA34FE@shsmsx502.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/24/2011 02:30 PM, Tian, Kevin wrote: > > > > We don't do that. vcpu migration calls vcpu_clear() with interrupts > > enabled, which then calls smp_call_function_single(), which calls > > __vcpu_clear() with interrupts disabled. vmclear_local_vcpus() is > > called from interrupts disabled (and calls __vcpu_clear() directly). > > > > OK, that's clear to me now. Are there still open issues about the patch? (Nadav, please post patches in the future in new threads so they're easier to find) -- error compiling committee.c: too many arguments to function