From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932070Ab1EYMMK (ORCPT ); Wed, 25 May 2011 08:12:10 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:33701 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756358Ab1EYMMJ (ORCPT ); Wed, 25 May 2011 08:12:09 -0400 Message-ID: <4DDCF20B.4080701@ti.com> Date: Wed, 25 May 2011 13:11:55 +0100 From: Liam Girdwood User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Mark Brown CC: Nicolas Ferre , "linux-arm-kernel@lists.infradead.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoc: wm8731: fix wm8731_check_osc() connected condition References: <1306230657-28649-1-git-send-email-nicolas.ferre@atmel.com> <20110525111529.GC10797@opensource.wolfsonmicro.com> In-Reply-To: <20110525111529.GC10797@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/05/11 12:15, Mark Brown wrote: > On Tue, May 24, 2011 at 11:50:57AM +0200, Nicolas Ferre wrote: >> The crystal oscillator is only enabled if the WM8731_SYSCLK_XTAL master clock >> is specified. Fix the connected() struct snd_soc_dapm_route function to take >> this into account. Oscillator is not enabled on machine that need it otherwise. >> >> Machine drivers have to make sure that they use the proper SYSCLK value. >> >> Signed-off-by: Nicolas Ferre > > Adding Liam - Nicolas, please remember to CC all maintainers on patches. > Acked-by: Liam Girdwood From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] ASoc: wm8731: fix wm8731_check_osc() connected condition Date: Wed, 25 May 2011 13:11:55 +0100 Message-ID: <4DDCF20B.4080701@ti.com> References: <1306230657-28649-1-git-send-email-nicolas.ferre@atmel.com> <20110525111529.GC10797@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by alsa0.perex.cz (Postfix) with ESMTP id 46FAB10380F for ; Wed, 25 May 2011 14:12:00 +0200 (CEST) In-Reply-To: <20110525111529.GC10797@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: "alsa-devel@alsa-project.org" , Nicolas Ferre , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org On 25/05/11 12:15, Mark Brown wrote: > On Tue, May 24, 2011 at 11:50:57AM +0200, Nicolas Ferre wrote: >> The crystal oscillator is only enabled if the WM8731_SYSCLK_XTAL master clock >> is specified. Fix the connected() struct snd_soc_dapm_route function to take >> this into account. Oscillator is not enabled on machine that need it otherwise. >> >> Machine drivers have to make sure that they use the proper SYSCLK value. >> >> Signed-off-by: Nicolas Ferre > > Adding Liam - Nicolas, please remember to CC all maintainers on patches. > Acked-by: Liam Girdwood From mboxrd@z Thu Jan 1 00:00:00 1970 From: lrg@ti.com (Liam Girdwood) Date: Wed, 25 May 2011 13:11:55 +0100 Subject: [PATCH] ASoc: wm8731: fix wm8731_check_osc() connected condition In-Reply-To: <20110525111529.GC10797@opensource.wolfsonmicro.com> References: <1306230657-28649-1-git-send-email-nicolas.ferre@atmel.com> <20110525111529.GC10797@opensource.wolfsonmicro.com> Message-ID: <4DDCF20B.4080701@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 25/05/11 12:15, Mark Brown wrote: > On Tue, May 24, 2011 at 11:50:57AM +0200, Nicolas Ferre wrote: >> The crystal oscillator is only enabled if the WM8731_SYSCLK_XTAL master clock >> is specified. Fix the connected() struct snd_soc_dapm_route function to take >> this into account. Oscillator is not enabled on machine that need it otherwise. >> >> Machine drivers have to make sure that they use the proper SYSCLK value. >> >> Signed-off-by: Nicolas Ferre > > Adding Liam - Nicolas, please remember to CC all maintainers on patches. > Acked-by: Liam Girdwood