From: Alex Waterman <awaterman@dawning.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [NAND] Fixes 16bit NAND support with the NDFC
Date: Thu, 26 May 2011 14:33:59 -0400 [thread overview]
Message-ID: <4DDE9D17.1070907@dawning.com> (raw)
In-Reply-To: <20110526111100.18e5e0bf@schlenkerla.am.freescale.net>
Scott,
> Looks mostly OK to me -- I was going to consider it for next, rather than
> master, as despite "fix" in the name it's really adding new hardware support.
Ahh, yeah, that makes sense. I will change "Fixes" to "Adds" for next
submission.
> You may want to use an #ifdef for bus width in nand_boot.c rather than
> spending bytes to check it dynamically.
OK. I suppose its unlikely that a NAND chip will swap from 8bit to 16bit (or
vice versa) from one compile to another :).
> Likewise in the non-SPL driver code, you already have
> CONFIG_SYS_NDFC_16BIT, so why check dynamically in ndfc_read_byte()?
My thought process was something along the lines of one compiled binary working
on potentially multiple similar boards... Though in thinking about it, that
seems like a needless requirement. I will change to #ifdefs for smaller code
size. That's probably more useful overall.
Regards,
Alex
--
Alex Waterman
Computer Engineer
Phone: 215-896-4920
Email: awaterman at dawning.com
prev parent reply other threads:[~2011-05-26 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 19:30 [U-Boot] [PATCH] [NAND] Fixes 16bit NAND support with the NDFC Alex Waterman
2011-05-19 19:50 ` Wolfgang Denk
2011-05-19 20:23 ` Alex Waterman
2011-05-26 13:40 ` Alex Waterman
2011-05-26 16:11 ` Scott Wood
2011-05-26 18:33 ` Alex Waterman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE9D17.1070907@dawning.com \
--to=awaterman@dawning.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.