From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQblY-0005fJ-3J for qemu-devel@nongnu.org; Sun, 29 May 2011 04:54:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQblW-0007sV-TZ for qemu-devel@nongnu.org; Sun, 29 May 2011 04:54:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQblW-0007s2-Dz for qemu-devel@nongnu.org; Sun, 29 May 2011 04:54:30 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4T8sTwx016062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 29 May 2011 04:54:29 -0400 Message-ID: <4DE209C1.4080807@redhat.com> Date: Sun, 29 May 2011 11:54:25 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20110523213115.164535428@amt.cnet> <20110523213411.003695437@amt.cnet> In-Reply-To: <20110523213411.003695437@amt.cnet> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [patch 6/7] QEMU live block copy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org On 05/24/2011 12:31 AM, Marcelo Tosatti wrote: > Support live image copy + switch. That is, copy an image backing > a guest hard disk to a destination image (destination image must > be created separately), and switch to this copy. > > Command syntax: > > block_copy device filename [-i] -- live block copy device to image > -i for incremental copy (base image shared between src and destination) > > Please refer to qmp-commands diff for more details. IMO it would have been nicer to use the mirror driver for all copying; there would be no STAGE_DIRTY; simply a background process that copies over all blocks, taking care not to conflict with ongoing writes. It would also remove the conflict with migration. But that's an implementation detail and can be changed later. -- error compiling committee.c: too many arguments to function