From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio M. Di Nitto <fdinitto@redhat.com>
Date: Wed, 01 Jun 2011 06:28:10 +0200
Subject: [Cluster-devel] [PATCH] Add i18n infra-structure.
In-Reply-To: <1306870631-27386-1-git-send-email-cmaiolino@redhat.com>
References: <1306870631-27386-1-git-send-email-cmaiolino@redhat.com>
Message-ID: <4DE5BFDA.2010404@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 05/31/2011 09:37 PM, Carlos Maiolino wrote:
> This patch adds some files, directories and changes in configure.ac and Makefile.am required to i18n support.
> 
> The previous patch missed changes in configure.ac and Makefile.am, this is the correct one
> 
> ---
>  Makefile.am            |    4 +-
>  config.rpath           |  672 ++++++++++++++++++++++++++++++++++++++++++++++++

Why do we need config.rpath? What does it do in this context?

> diff --git a/configure.ac b/configure.ac
> index 3fc02d0..aa7cc64 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -16,6 +16,10 @@ AC_PROG_LIBTOOL
>  
>  AC_LANG([C])
>  
> +#i18n
> +AM_GNU_GETTEXT
> +AM_GNU_GETTEXT_VERSION([0.18])
> +
>  # Sanitize path
>  
>  if test "$prefix" = "NONE"; then
> @@ -262,7 +266,7 @@ CPPFLAGS="$KERNEL_CPPFLAGS -I\$(top_builddir)/make -I\$(top_srcdir)/make \
>  	  -I. $ENV_CPPFLAGS"
>  LDFLAGS="$ENV_LDFLAGS"
>  
> -AC_CONFIG_FILES([Makefile
> +AC_CONFIG_FILES([Makefile intl/Makefile po/Makefile.in
>  		 group/Makefile
>  		 group/libgfscontrol/Makefile
>  		 group/gfs_control/Makefile

One per line, in alphabetical order please. Easier to track them.

Same applies to Makefile.am addition for SUBDIRS and EXTRA_DIST.

Is the build order important for po/intl vs code?

Fabio