All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>,
	Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
Subject: Re: [GIT PATCHES FOR 2.6.41] Add bitmask controls
Date: Wed, 01 Jun 2011 09:55:33 -0300	[thread overview]
Message-ID: <4DE636C5.7040604@redhat.com> (raw)
In-Reply-To: <201105231315.29328.hverkuil@xs4all.nl>

Hi Hans,

Em 23-05-2011 08:15, Hans Verkuil escreveu:
> Hi Mauro,
> 
> These patches for 2.6.41 add support for bitmask controls, needed for the
> upcoming Flash API and HDMI API.

DocBook changes need do a s/2.6.41/3.1/. 

That's said, I'm not sure if it is a good idea to add bitmask type, instead of
just using a set of boolean controls. One of the issues with bitmasks is the
endness type: LE, BE or machine endianness. The specs don't mention how this
is supposed to work.

Also, I'd like to see a patch like that submitting with a driver or feature
that needs it. Before you ask: no, vivi doesn't count ;)

> Sakari, can you give your ack as well?
> 
> The patch is the same as the original one posted April 4, except for a small
> change in the control logging based on feedback from Laurent and the new
> DocBook documentation.

Cheers,
Mauro

  parent reply	other threads:[~2011-06-01 12:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 11:15 [GIT PATCHES FOR 2.6.41] Add bitmask controls Hans Verkuil
2011-05-24  7:49 ` Sakari Ailus
2011-06-01 12:55 ` Mauro Carvalho Chehab [this message]
2011-06-01 13:27   ` Hans Verkuil
2011-06-01 13:41     ` Mauro Carvalho Chehab
2011-06-05 13:28       ` Sakari Ailus
2011-06-08 10:54         ` Sakari Ailus
2011-06-08 11:04           ` Hans Verkuil
2011-06-08 11:06             ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE636C5.7040604@redhat.com \
    --to=mchehab@redhat.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@maxwell.research.nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.