From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758450Ab1FAPbW (ORCPT ); Wed, 1 Jun 2011 11:31:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47427 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757914Ab1FAPbU (ORCPT ); Wed, 1 Jun 2011 11:31:20 -0400 Message-ID: <4DE65B3A.9070706@redhat.com> Date: Wed, 01 Jun 2011 11:31:06 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.1 MIME-Version: 1.0 To: Minchan Kim CC: Andrew Morton , linux-mm , LKML , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Mel Gorman , Andrea Arcangeli , Johannes Weiner Subject: Re: [PATCH v2 02/10] compaction: trivial clean up acct_isolated References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2011 02:13 PM, Minchan Kim wrote: > acct_isolated of compaction uses page_lru_base_type which returns only > base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. > In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have > fields in conpact_control. > This patch removes fields from compact_control and makes clear function of > acct_issolated which counts the number of anon|file pages isolated. > > Cc: KOSAKI Motohiro > Cc: Mel Gorman > Cc: Rik van Riel > Cc: Andrea Arcangeli > Cc: Johannes Weiner > Reviewed-by: KAMEZAWA Hiroyuki > Signed-off-by: Minchan Kim Acked-by: Rik van Riel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id AD19F6B0011 for ; Wed, 1 Jun 2011 11:31:16 -0400 (EDT) Message-ID: <4DE65B3A.9070706@redhat.com> Date: Wed, 01 Jun 2011 11:31:06 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH v2 02/10] compaction: trivial clean up acct_isolated References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Mel Gorman , Andrea Arcangeli , Johannes Weiner On 05/29/2011 02:13 PM, Minchan Kim wrote: > acct_isolated of compaction uses page_lru_base_type which returns only > base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. > In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have > fields in conpact_control. > This patch removes fields from compact_control and makes clear function of > acct_issolated which counts the number of anon|file pages isolated. > > Cc: KOSAKI Motohiro > Cc: Mel Gorman > Cc: Rik van Riel > Cc: Andrea Arcangeli > Cc: Johannes Weiner > Reviewed-by: KAMEZAWA Hiroyuki > Signed-off-by: Minchan Kim Acked-by: Rik van Riel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org