From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSEGk-0002GP-9n for qemu-devel@nongnu.org; Thu, 02 Jun 2011 16:13:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QSEGd-0006Za-Cb for qemu-devel@nongnu.org; Thu, 02 Jun 2011 16:13:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QSEGc-0006ZB-Tf for qemu-devel@nongnu.org; Thu, 02 Jun 2011 16:13:19 -0400 Message-ID: <4DE7EED6.2090609@redhat.com> Date: Thu, 02 Jun 2011 14:13:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <20110601181255.077fb5fd@doriath> <4DE6B087.6010708@codemonkey.ws> <20110602145730.4c80d668@doriath> <4DE7CFA4.9040300@codemonkey.ws> <20110602150900.7d2657fb@doriath> <4DE7D790.70807@codemonkey.ws> <20110602161318.0d9a2194@doriath> <4DE7ECA8.1050202@codemonkey.ws> In-Reply-To: <4DE7ECA8.1050202@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig09EA43008F1EA19961370874" Subject: Re: [Qemu-devel] [libvirt] QMP: RFC: I/O error info & query-stop-reason List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , "libvir-list@redhat.com" , jdenemar@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig09EA43008F1EA19961370874 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/02/2011 02:03 PM, Anthony Liguori wrote: >>>>>>>> { "event": "BLOCK_IO_ERROR", >>>>>>>> "data": { "device": "ide0-hd1", >>>>>>>> "operation": "write", >>>>>>>> "action": "stop", >>>>>>>> "reason": "enospc", } >>>>>>> >>>>>> I'm ok with either way. But in case you meant the second one, I gu= ess >>>>>> we should make "reason" a dictionary so that we can group related >>>>>> information when we extend the field, for example: >>>>>> >>>>>> "reason": { "no space": false, "no permission": true } The idea for an event with details certainly has merit. >>>>> >>>>> Why would we ever have "no permission"? SELinux denial, perhaps? >=20 >> Maybe libvirt guys could provide more input wrt the error reason usage= =2E >> If we don't have valid use cases for other errors, then I'll agree tha= t >> providing only "no space" is enough. >=20 > Definitely! Adding libvirt to the CC to help encourage their input. We could always start with just one reason "no space", and add more later if and when we come up for use cases. --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enig09EA43008F1EA19961370874 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJN5+7WAAoJEKeha0olJ0NqtP4IAJFdl7cCCiYtx8Uyuaog8B8q YSPF70snYxVkORQ0MfEaeqIbRq4Byzs+h0a3OoDa5QCscGcNskagjwBoq6KJXt53 y9IhmUvlylU8KLWnYzVlqLGEipO36FB0nPONu7vWakvC0IalB9nWiVScw81W+Qk3 Tu1qtWZWTf2LyY6LOK9SfyFxkrL5/RDlChMXh3VCW0Adnz7IEPIyvi9MnVGx+qzM dCIj+LevHmT9Y+6F4/vpNyjPQ+8J+nSJEDxYOvEi1wRmI5X8g7JBm+9Wo7Kt/Nua 3vrStrbQgiYnNMoON270OZXSa3xc0ofMzp+tM+8H5B04sNlfqysEP4BJ0crHSWI= =UO0p -----END PGP SIGNATURE----- --------------enig09EA43008F1EA19961370874--