From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTwxu-00055Z-Tl for qemu-devel@nongnu.org; Tue, 07 Jun 2011 10:09:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTwxr-0005Nd-PY for qemu-devel@nongnu.org; Tue, 07 Jun 2011 10:09:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTwxr-0005ND-Ce for qemu-devel@nongnu.org; Tue, 07 Jun 2011 10:09:03 -0400 Message-ID: <4DEE31A8.1090603@redhat.com> Date: Tue, 07 Jun 2011 16:11:52 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <20110519085748.GA3650@lst.de> <20110607111326.GA6273@lst.de> In-Reply-To: <20110607111326.GA6273@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] ide: add TRIM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Am 07.06.2011 13:13, schrieb Christoph Hellwig: > ping? Sorry, forgot to answer... The problem that I had with this was that you add to the BM status register abuse with BM_STATUS_RETRY_TRIM. I intended to look into this and then review the rest of it. We'll need to have a fix for all the other abused bits anyway, so I guess we can as well temporarily abuse one more bit (it happens to be reserved/hardwired to 0 in my specs) and fix it only on top. Kevin