From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPtr-0007Ca-CP for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:02:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QUPtn-00025r-W2 for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:02:51 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:41222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QUPtn-00025Q-HG for qemu-devel@nongnu.org; Wed, 08 Jun 2011 17:02:47 -0400 Message-ID: <4DEFE374.7010009@web.de> Date: Wed, 08 Jun 2011 23:02:44 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <219d3206ad6eafed76d4f108a40912fe72884e19.1307550106.git.jan.kiszka@siemens.com> <20110608195316.GD30805@redhat.com> <4DEFE00A.5050005@web.de> <20110608210005.GB32260@redhat.com> In-Reply-To: <20110608210005.GB32260@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBB5C4676BC843E9DB6ABEF22" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBB5C4676BC843E9DB6ABEF22 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-08 23:00, Michael S. Tsirkin wrote: > On Wed, Jun 08, 2011 at 10:48:10PM +0200, Jan Kiszka wrote: >> On 2011-06-08 21:53, Michael S. Tsirkin wrote: >>> On Wed, Jun 08, 2011 at 06:21:51PM +0200, Jan Kiszka wrote: >>>> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related consta= nt >>>> names to libpci style. Will be used for device assignment code in >>>> qemu-kvm. >>>> >>>> Signed-off-by: Jan Kiszka >>> >>> Besides keeping pci_regs.h aligned with the original, >>> I also think ideally pci register banging should stay >>> within the pci subsystem. >>> >>> Could we add high-level APIs to help with that, >>> instead of having kvm look at config space directly? >> >> We could move the related static inlines from msi/msix.c to the header= s >> in order to test for bits etc. Still, kvm needs to interpret the confi= g >> space of the assigned device, so the abstraction will remain rather lo= w. >> >> Jan >> >=20 > Hmm, at least for MSI/MSIX I thought this is done by kvm in kernel? >=20 At least for the "traditional" assignment interface (VFIO may offload something), no. User space does the cap analysis, filtering, and in the MSI/MSI-X case the translation to QEMU msi/msix services. The latter is even WIP in my tree. Surrent assignment open-codes this, missing many corner cases. Jan --------------enigBB5C4676BC843E9DB6ABEF22 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk3v43UACgkQitSsb3rl5xSc9gCgr0u2gMrAtkSbHakl7D+dtVlf AX8AoMtbKFHJ9eQnPDXVprJBgujrM9hn =Xrju -----END PGP SIGNATURE----- --------------enigBB5C4676BC843E9DB6ABEF22--