From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Fri, 17 Jun 2011 12:32:38 +0530 Subject: [U-Boot] SPL framework re-design In-Reply-To: <20110616220900.0746C19E5AC5@gemini.denx.de> References: <4DF9B9E0.8020206@ti.com> <20110616114556.7d3c2a78@schlenkerla.am.freescale.net> <20110616220900.0746C19E5AC5@gemini.denx.de> Message-ID: <4DFAFC0E.7060208@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 17 June 2011 03:39 AM, Wolfgang Denk wrote: > Dear Scott Wood, > > In message<20110616114556.7d3c2a78@schlenkerla.am.freescale.net> you wrote: >> >> What is a "generic SPL library", or even a "generic NAND SPL library"? >> >> There is no code that is shared by all NAND SPLs. The files directly under >> "nand_spl/" are alternatives that the board makefile can choose. > > I think there is tons of duplicated code that could and should be > extraced into common directories. > >> Counterproposal: keep the basic structure the same, but refactor the >> makefiles so that they use a common template but supply their own policy. >> >> That is, the board makefile would just set some variables to be lists of >> objects it's interested in (and any other relevant tunables, or special >> rules), and then include the common SPL makefile that will do all the >> symlinking and building. > > Or put this from the head on it's feet and use a board specific > config.mk which gets included by the SPL makefile? And also 'config.mk's that are SoC specific, CPU specific etc? Otherwise the board specific config.mk will still duplicate SoC and CPU content. best regards, Aneesh