From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH 1/2] m68knommu: create config options for CPU classes
Date: Thu, 23 Jun 2011 11:35:50 +1000 [thread overview]
Message-ID: <4E029876.6040507@snapgear.com> (raw)
In-Reply-To: <BANLkTikuR5tNe=CQS9qCOJHGkKUWKmO-rw@mail.gmail.com>
Hi Geert,
On 03/06/11 21:15, Geert Uytterhoeven wrote:
> On Fri, Jun 3, 2011 at 08:43,<gerg@snapgear.com> wrote:
>> From: Greg Ungerer<gerg@uclinux.org>
>>
>> There are 3 families of CPU core types that we support in the m68knommu
>> architecture branch. They are
>>
>> . traditional 68000
>> . CPU32 (which is a 68020 core derivitive without MMU)
>
> derivative ... and without bitfield instructions.
>
>> . ColdFire
>
>> It will be useful going forward to have a CONFIG_ option defined for
>> each type. We already have one for ColdFire (CONFIG_COLDFIRE), so add
>> for the other 2 families, CONFIG_M68000 and CONFIG_MCPU32.
>
> I'm wondering whether it would help to have Kconfig symbols for the
> instruction capabilities as well.
> Then you have to document these capabilities in the kconfig definition only,
> and can use single (e.g.) #ifdef CONFIG_CPU_HAS_BITFIELDS tests everywhere
> else, instead of duplicating the logic at every #ifdef.
I have just posted a modified version of the bitops.h merge that
creates and uses a CONFIG_CPU_HAS_BITFIELDS option. The patch is
otherwise the same in terms of changes, just uses this define
for the ifdefs.
If you/others prefer this we can run with this one.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2011-06-23 1:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 6:43 [PATCH 0/2] m68knommu: fix cpu optimization conditionals gerg
2011-06-03 6:43 ` gerg
2011-06-03 6:43 ` [PATCH 1/2] m68knommu: create config options for CPU classes gerg
2011-06-03 11:15 ` Geert Uytterhoeven
2011-06-06 1:49 ` Greg Ungerer
2011-06-10 3:56 ` Greg Ungerer
2011-06-12 9:36 ` Geert Uytterhoeven
2011-06-23 1:35 ` Greg Ungerer [this message]
2011-06-03 6:43 ` [PATCH 2/2] m68k: use kernel processor defines for conditional optimizations gerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E029876.6040507@snapgear.com \
--to=gerg@snapgear.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.