From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023Ab1F2LKZ (ORCPT ); Wed, 29 Jun 2011 07:10:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13733 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754957Ab1F2LKY (ORCPT ); Wed, 29 Jun 2011 07:10:24 -0400 Message-ID: <4E0B081B.4080306@redhat.com> Date: Wed, 29 Jun 2011 14:10:19 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: Xiao Guangrong CC: Marcelo Tosatti , LKML , KVM Subject: Re: [PATCH v2 07/22] KVM: MMU: cache mmio info on page fault path References: <4E01FBC9.3020009@cn.fujitsu.com> <4E01FCA8.3050401@cn.fujitsu.com> <4E0AE6D5.6080205@redhat.com> <4E0B07F0.5020503@cn.fujitsu.com> In-Reply-To: <4E0B07F0.5020503@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2011 02:09 PM, Xiao Guangrong wrote: > On 06/29/2011 04:48 PM, Avi Kivity wrote: > > On 06/22/2011 05:31 PM, Xiao Guangrong wrote: > >> If the page fault is caused by mmio, we can cache the mmio info, later, we do > >> not need to walk guest page table and quickly know it is a mmio fault while we > >> emulate the mmio instruction > > > > Does this work if the mmio spans two pages? > > > > If the mmio spans two pages, we already split the emulation into two parts, > and the mmio cache info is only matched for one page, so i thinks it works > well :-) Ok, thanks. -- error compiling committee.c: too many arguments to function