From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Thu, 30 Jun 2011 16:48:45 +0530 Subject: [U-Boot] [RFC PATCH 6/7] omap: common spl support for OMAP3/4 In-Reply-To: <4E0C5961.1030505@aribaud.net> References: <1309352967-5719-7-git-send-email-aneesh@ti.com> <4E0C113B.3070303@denx.de> <4E0C13D0.5040001@ti.com> <4E0C2B65.5030404@denx.de> <4E0C5961.1030505@aribaud.net> Message-ID: <4E0C5B95.7030404@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 30 June 2011 04:39 PM, Albert ARIBAUD wrote: > Hi Simon, > > Le 30/06/2011 10:21, Simon Schwarz a ?crit : >> Hi, >> >>> Hmm, I actually porting a dm368 based board with nand_spl support >>> (patches following soon), and there I have an empty bss section, >>> so I can direct copy the u-boot image from nand to ram in board_init_f(). >> >> This is what I'am doing with OMAP3 also. IMHO it would be more >> readable if relocate_code is not called if there is no relocation and >> instead the clear_bss()-function is used as Andreas suggested. (Or to >> just not use clear_bss if bss is empty) > > IMO, for the sake of rpbustness, the clear_bss code should handle the > case where the BSS is empty, and for the sake of simplicity, it should > be called always. I shall check the case when BSS is empty and fix it if needed. br, Aneesh